From: Paul Eggert <eggert@cs.ucla.edu>
To: Philipp Stephani <p.stephani2@gmail.com>,
Philipp Stephani <phst@google.com>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Silence two Clang warnings
Date: Thu, 15 Jun 2017 11:56:56 -0700 [thread overview]
Message-ID: <a536bbb0-c64b-3943-ba5e-dc58abae1a74@cs.ucla.edu> (raw)
In-Reply-To: <CAArVCkRVtQc8Vw9PQ1aAgSegi5YVqwGHN+=CewpViPmeBCfRMQ@mail.gmail.com>
On 06/15/2017 06:11 AM, Philipp Stephani wrote:
> Would you accept introducing pragmas to temporarily disable the
> warnings in Clang (#pragma clang diagnostic push/ignore/pop), with an
> explanation why they are false positives in these cases?
That depends on what the warnings are and how useful they are elsewhere.
These particular warnings do not seem to be useful for Emacs. For
example, it is common practice in Emacs's C macros to parenthesize
expressions to avoid operator-precedence confusion, and if Clang is
complaining about the "extra" parentheses in the preprocessor output
then that's clearly a warning that we should just shut off. Our goal is
clarity and reliability, not Clang pacification.
next prev parent reply other threads:[~2017-06-15 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 20:42 Silence two Clang warnings Paul Eggert
2017-06-15 13:11 ` Philipp Stephani
2017-06-15 18:56 ` Paul Eggert [this message]
2017-06-15 19:23 ` Philipp Stephani
2017-06-15 19:35 ` Paul Eggert
2017-06-16 16:53 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a536bbb0-c64b-3943-ba5e-dc58abae1a74@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).