From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Date: Sun, 2 May 2021 02:43:20 +0200 Message-ID: References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <24f3b5e7-3e5e-d00f-3fc4-9d093ca1dc10@daniel-mendler.de> <87fsz7wvu5.fsf@mail.linkov.net> <46a170c1-7d81-8ed5-e61a-d8193b640d16@daniel-mendler.de> <877dkirzvn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24021"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Dmitry Gutov , Stefan Monnier , "emacs-devel@gnu.org" To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 02 02:45:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ld0EZ-00068R-SC for ged-emacs-devel@m.gmane-mx.org; Sun, 02 May 2021 02:45:19 +0200 Original-Received: from localhost ([::1]:48730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ld0EY-000318-TS for ged-emacs-devel@m.gmane-mx.org; Sat, 01 May 2021 20:45:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ld0Cl-000212-3k for emacs-devel@gnu.org; Sat, 01 May 2021 20:43:27 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:40717 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ld0Cj-0006jB-8Z for emacs-devel@gnu.org; Sat, 01 May 2021 20:43:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vfuti1TT14dKvPrcFFQFZP6fHOqJWcuGK/mkdpVgdNo=; b=noxfdgu5VwbtOIV0SCSlfNzt7E /3tSnl20q3ajU06GexBQ7n6cwFNKu9dUhtjhMIJ5uAKc7cjE8SiUtjN7XACRi6N+nYdzG5WSK4LV4 /HX06WrhRNE9dWi+KFVZDfmx436EvhAK+9ccXt1PFgZWSwlfmSKyghD2vGEmK+KV+pEc=; In-Reply-To: <877dkirzvn.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268742 Archived-At: On 5/1/21 9:57 PM, Juri Linkov wrote:>> This seems to me like a mix of vertical and horizontal layout. > > It's still the vertical layout but with grouping > similar to how you sort candidates in every group, > only here the per-group candidates are arranged vertically. > > Maybe this choice could be handled by an option? Of course, we can add options to allow fine tuning of every behavior. While I like the tuneability of Emacs I am not sure if it is advised to make every tiny bit configurable. The way I wrote the current patch allows the addition of custom `completions--insert-*` functions. Furthermore there is always the advice mechanism, the possibility to override functions etc, so I don't feel the need to add configurations for every detail. In my patch, I made this choice since it seemed more natural given the distinction of horizontal and vertical insertion. By using a more horizontal-like grouping, the distinction between the styles would be less pronounced. However the arrangement you proposed is also reasonable. I don't feel strongly about this and I am not against offering this as configurable option or even as sole option. In the patches are there more concrete issues which need to be addressed? Daniel