From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: master 5b3c4004a9 2/2: Remove calls to intern with a static string from code that runs on X Date: Mon, 19 Sep 2022 07:42:05 +0000 Message-ID: References: <166355307855.3830.3892166668612546304@vcs2.savannah.gnu.org> <20220919020439.67823C00874@vcs2.savannah.gnu.org> <874jx328ye.fsf@gnus.org> <877d1zsufw.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37573"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 19 09:53:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaBbK-0009Z7-Eh for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 09:53:58 +0200 Original-Received: from localhost ([::1]:59366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaBbI-0005xB-WE for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 03:53:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaBPt-00081S-Ro for emacs-devel@gnu.org; Mon, 19 Sep 2022 03:42:09 -0400 Original-Received: from heytings.org ([95.142.160.155]:46650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaBPs-0002wn-3L for emacs-devel@gnu.org; Mon, 19 Sep 2022 03:42:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1663573325; bh=30AXjYFGDLHZnQU8GvJJ9qGXgeHobIkQUTozIZ+P2ms=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=gd6UwTVEO2lH7b1fuHezGlbEWmaRDWoiOPhN7HRzrqD1ixjZ5whzmogKPS5+rcmNW mrNL8Mj8RVqI8aRz/14Pts6U7Urqpxe8eRoAk/LTu5Ua0W+PMI5rdrepQ6oCSOAg35 EzDNsxIWZKR4iPbpNVvFUGZ+IQcHP0XuXD7AjwKKvAOOba/4VIcZqphaSYBUaENzER l2VEjS/jqiHVqVCz3FXHGPceeTjZWczAfsNop/6Mvob14b2A9t/2BBzanDkzC41voY zoqqxuyWXD8d4jBFnV+7avqTV5eIxjXHKbQOSqeKCkesudwGnkLAo5NgrTjwzBeZCs CVz2YtJ3xnXTA== In-Reply-To: <877d1zsufw.fsf@yahoo.com> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295625 Archived-At: Po Lu, it is unacceptable to "reword" a patch that has been discussed publicly over a week. You had plenty of time to comment on it if you wanted. The fact that the advice message is indented for example is intentional, it stands out better. I now reverted you commits again, and added a mention about make extraclean (which is what "make bootstrap configure=default" does).