From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spyros Roum Newsgroups: gmane.emacs.devel Subject: Re: Add completion to compilation-read-command Date: Tue, 24 Dec 2024 18:59:58 +0000 Message-ID: References: <87ttatb9g0.fsf@posteo.net> <87a5clm3p5.fsf@mail.linkov.net> <87o710j4pf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------J3pF8YTr2nxoYd5acjLO0100" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28035"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org To: juri@linkov.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 24 20:00:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQA9C-00077V-Ni for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Dec 2024 20:00:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQA8M-0006A4-Na; Tue, 24 Dec 2024 13:59:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQA8L-00069b-1u for emacs-devel@gnu.org; Tue, 24 Dec 2024 13:59:57 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQA8I-00042m-9P for emacs-devel@gnu.org; Tue, 24 Dec 2024 13:59:56 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BB717240101 for ; Tue, 24 Dec 2024 19:59:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735066790; bh=4n+eIYLjCaxAmvwpGIryhkPLtcrtBouR2KClroLXkKs=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:Cc:From: From; b=BgQSWPZzjYhTA3eDBtdGa7z9Zx0zZ2tXUwz/k05WGXEd5fQOCWl7lPheceh13AUQY V6n7N8dI6ZEKauT4wVX8SesHy/E/s/Ap8LZ+Tr1ByayX/1CnDCnI+98YeqULsUKsz+ W3oubKXsqDhWttu3FmuWCKuSvffzYZEXYBN5G9m+Y9RbWGQHRLNuwosHKwZAPDXwHo EnxiRSZRdA6s+jvlnBWyQpSpTcMlnzNi+r4z5hUta1CaThE11OdyIZsbeFv8S3NK+2 acJm+5CGgF4PJqFSAaPlFhJuIppSCNIrUXaJwHOYHgbiV5Eg2cM8AXQmconXloB6y9 sGl8ROj/mY0FA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHkj052mJz6tm4; Tue, 24 Dec 2024 19:59:48 +0100 (CET) Content-Language: en-US, el, el-en In-Reply-To: <87o710j4pf.fsf@mail.linkov.net> Received-SPF: pass client-ip=185.67.36.66; envelope-from=spyros.roum@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327028 Archived-At: This is a multi-part message in MIME format. --------------J3pF8YTr2nxoYd5acjLO0100 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Juri Linkov wrote: >>> You can use 'C-x ' in the compile prompt to complete on past commands. >> This is indeed a lot closer to what I want, however it still lacks a lot of >> things compared to my solution. >> >> Unless there is some package/mode I don't know about, It's a lot less >> dynamic, for instance I can't keep typing to reduce possible items. > There were many proposals how to implement `eager-update' to update > *Completions* as you type. We just need to put together all parts. I'm probably out of my depth here, as I'm not very familiar with *Completions*. Is there a good reason to stick to it when `completing-read` works well and as far as I can tell does a very similar/the same job? I have a patch almost ready based on Philip's feedback that I will be sharing today or tomorrow. If, however, the consensus is that it's not a good fit and that `C-x ` and *Completions* is good enough, that's fine by me. --------------J3pF8YTr2nxoYd5acjLO0100 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
Juri Linkov wrote:
You can use 'C-x <up>' in the compile prompt to complete on past commands.

This is indeed a lot closer to what I want, however it still lacks a lot of
things compared to my solution. 

Unless there is some package/mode I don't know about, It's a lot less
dynamic, for instance I can't keep typing to reduce possible items. 

There were many proposals how to implement `eager-update' to update
*Completions* as you type.  We just need to put together all parts.

I'm probably out of my depth here, as I'm not very familiar with *Completions*.
Is there a good reason to stick to it when `completing-read` works well and as far as I can tell
does a very similar/the same job?

I have a patch almost ready based on Philip's feedback that I will be sharing today or tomorrow.
If, however, the consensus is that it's not a good fit and that `C-x <up>` and *Completions* is good enough,
that's fine by me.

--------------J3pF8YTr2nxoYd5acjLO0100--