From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-28 9c222b9: Port to C compilers that lack size-0 arrays
Date: Fri, 3 Dec 2021 08:46:23 -0800 [thread overview]
Message-ID: <a1b5bffd-38c5-42f1-2722-bdca8bfa4e63@cs.ucla.edu> (raw)
In-Reply-To: <83bl1y85np.fsf@gnu.org>
On 12/3/21 00:16, Eli Zaretskii wrote:
> We have already started the pretest.
Yes, and the pretest is why I found the problems I fixed: I built and
tested on less-common platforms that I normally don't bother with.
> How serious is the problem this attempts to solve, and what bad things
> will happen if we release Emacs 28.1 without those changes?
What I experienced was a ton of diagnostics with both the Oracle Solaris
and the IBM AIX C compilers, which made it difficult for me to see the
real problems on those platforms (of which there were some). Although I
was able to finish the builds anyway, the old code was a clear violation
of the C89/C99/C11 standards and a good indication that there will be
problems building on other less-common platforms that I don't have
access to.
Conforming to the C standard doesn't affect behavior here (it possibly
doesn't even change the machine code, though I didn't check this) so I
considered the change to be a safe prophylactic.
next prev parent reply other threads:[~2021-12-03 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 8:16 emacs-28 9c222b9: Port to C compilers that lack size-0 arrays Eli Zaretskii
2021-12-03 16:46 ` Paul Eggert [this message]
2021-12-03 18:29 ` Eli Zaretskii
2021-12-03 19:42 ` Paul Eggert
2021-12-03 20:01 ` Eli Zaretskii
2021-12-03 23:32 ` Paul Eggert
2021-12-04 7:35 ` Eli Zaretskii
2021-12-04 10:47 ` Stefan Kangas
2021-12-04 11:24 ` Po Lu
2021-12-04 0:37 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1b5bffd-38c5-42f1-2722-bdca8bfa4e63@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).