* Re: [nongnu] elpa/clojure-ts-mode 649bf1120f: Improve the package version reporting [not found] ` <20240604075945.DB087C1F9CB@vcs2.savannah.gnu.org> @ 2024-06-04 9:09 ` Philip Kaludercic 2024-06-04 9:46 ` Bozhidar Batsov 0 siblings, 1 reply; 6+ messages in thread From: Philip Kaludercic @ 2024-06-04 9:09 UTC (permalink / raw) To: emacs-devel; +Cc: Bozhidar Batsov ELPA Syncer <elpasync@gnu.org> writes: > branch: elpa/clojure-ts-mode > commit 649bf1120f10250d464d4e9ad1905b481d2e504c > Author: Bozhidar Batsov <bozhidar@batsov.dev> > Commit: Bozhidar Batsov <bozhidar@batsov.dev> > > Improve the package version reporting > --- > clojure-ts-mode.el | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/clojure-ts-mode.el b/clojure-ts-mode.el > index 99f28cd20a..d2be3e737c 100644 > --- a/clojure-ts-mode.el > +++ b/clojure-ts-mode.el > @@ -54,7 +54,6 @@ > > ;;; Code: > (require 'treesit) > -(require 'lisp-mnt) > > (declare-function treesit-parser-create "treesit.c") > (declare-function treesit-node-eq "treesit.c") > @@ -71,8 +70,7 @@ > :link '(emacs-commentary-link :tag "Commentary" "clojure-mode")) > > (defconst clojure-ts-mode-version > - (eval-when-compile > - (lm-version (or load-file-name buffer-file-name))) > + "0.2.2" > "The current version of `clojure-ts-mode'.") > > (defcustom clojure-ts-comment-macro-font-lock-body nil > @@ -884,7 +882,10 @@ forms like deftype, defrecord, reify, proxy, etc." > (defun clojure-ts-mode-display-version () > "Display the current `clojure-mode-version' in the minibuffer." > (interactive) > - (message "clojure-ts-mode (version %s)" clojure-ts-mode-version)) > + (let ((pkg-version (package-get-version))) > + (if pkg-version > + (message "clojure-ts-mode %s (package: %s)" clojure-ts-mode-version pkg-version) > + (message "clojure-ts-mode %s" clojure-ts-mode-version)))) > > (defconst clojure-ts-grammar-recipes > '((clojure "https://github.com/sogaiu/tree-sitter-clojure.git" I don't understand the point of this change. If you duplicate the information of the package version anyway, then why use `package-get-version' at all? The only advantage this seems to bring is that if you forget to bump the version in `clojure-ts-mode-version' that you can find out about the discrepancy, but then it is too late and confusing. (Generally, I just don't think these kinds of "version information" commands are really useful anymore, at least since package management has become the widespread norm.) -- Philip Kaludercic on peregrine ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/clojure-ts-mode 649bf1120f: Improve the package version reporting 2024-06-04 9:09 ` [nongnu] elpa/clojure-ts-mode 649bf1120f: Improve the package version reporting Philip Kaludercic @ 2024-06-04 9:46 ` Bozhidar Batsov 2024-06-04 9:49 ` Bozhidar Batsov 2024-06-04 10:54 ` Philip Kaludercic 0 siblings, 2 replies; 6+ messages in thread From: Bozhidar Batsov @ 2024-06-04 9:46 UTC (permalink / raw) To: Philip Kaludercic, Emacs Devel [-- Attachment #1: Type: text/plain, Size: 2658 bytes --] I guess you having used MELPA, right? The package versions there are replaced with a timestamp, so they are not very useful if they are not complemented by the actual version. That's why for development versions I'd like to see them both in the user reports. On Tue, Jun 4, 2024, at 12:09 PM, Philip Kaludercic wrote: > ELPA Syncer <elpasync@gnu.org> writes: > > > branch: elpa/clojure-ts-mode > > commit 649bf1120f10250d464d4e9ad1905b481d2e504c > > Author: Bozhidar Batsov <bozhidar@batsov.dev> > > Commit: Bozhidar Batsov <bozhidar@batsov.dev> > > > > Improve the package version reporting > > --- > > clojure-ts-mode.el | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/clojure-ts-mode.el b/clojure-ts-mode.el > > index 99f28cd20a..d2be3e737c 100644 > > --- a/clojure-ts-mode.el > > +++ b/clojure-ts-mode.el > > @@ -54,7 +54,6 @@ > > > > ;;; Code: > > (require 'treesit) > > -(require 'lisp-mnt) > > > > (declare-function treesit-parser-create "treesit.c") > > (declare-function treesit-node-eq "treesit.c") > > @@ -71,8 +70,7 @@ > > :link '(emacs-commentary-link :tag "Commentary" "clojure-mode")) > > > > (defconst clojure-ts-mode-version > > - (eval-when-compile > > - (lm-version (or load-file-name buffer-file-name))) > > + "0.2.2" > > "The current version of `clojure-ts-mode'.") > > > > (defcustom clojure-ts-comment-macro-font-lock-body nil > > @@ -884,7 +882,10 @@ forms like deftype, defrecord, reify, proxy, etc." > > (defun clojure-ts-mode-display-version () > > "Display the current `clojure-mode-version' in the minibuffer." > > (interactive) > > - (message "clojure-ts-mode (version %s)" clojure-ts-mode-version)) > > + (let ((pkg-version (package-get-version))) > > + (if pkg-version > > + (message "clojure-ts-mode %s (package: %s)" clojure-ts-mode-version pkg-version) > > + (message "clojure-ts-mode %s" clojure-ts-mode-version)))) > > > > (defconst clojure-ts-grammar-recipes > > '((clojure "https://github.com/sogaiu/tree-sitter-clojure.git" > > I don't understand the point of this change. If you duplicate the > information of the package version anyway, then why use > `package-get-version' at all? The only advantage this seems to bring is > that if you forget to bump the version in `clojure-ts-mode-version' that > you can find out about the discrepancy, but then it is too late and > confusing. > > (Generally, I just don't think these kinds of "version information" > commands are really useful anymore, at least since package management > has become the widespread norm.) > > -- > Philip Kaludercic on peregrine > > [-- Attachment #2: Type: text/html, Size: 4303 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/clojure-ts-mode 649bf1120f: Improve the package version reporting 2024-06-04 9:46 ` Bozhidar Batsov @ 2024-06-04 9:49 ` Bozhidar Batsov 2024-06-04 10:54 ` Philip Kaludercic 1 sibling, 0 replies; 6+ messages in thread From: Bozhidar Batsov @ 2024-06-04 9:49 UTC (permalink / raw) To: Philip Kaludercic, Emacs Devel [-- Attachment #1: Type: text/plain, Size: 2805 bytes --] having => have not On Tue, Jun 4, 2024, at 12:46 PM, Bozhidar Batsov wrote: > I guess you having used MELPA, right? The package versions there are replaced with a timestamp, so they are not very useful if they are not complemented by the actual version. That's why for development versions I'd like to see them both in the user reports. > > On Tue, Jun 4, 2024, at 12:09 PM, Philip Kaludercic wrote: >> ELPA Syncer <elpasync@gnu.org> writes: >> >> > branch: elpa/clojure-ts-mode >> > commit 649bf1120f10250d464d4e9ad1905b481d2e504c >> > Author: Bozhidar Batsov <bozhidar@batsov.dev> >> > Commit: Bozhidar Batsov <bozhidar@batsov.dev> >> > >> > Improve the package version reporting >> > --- >> > clojure-ts-mode.el | 9 +++++---- >> > 1 file changed, 5 insertions(+), 4 deletions(-) >> > >> > diff --git a/clojure-ts-mode.el b/clojure-ts-mode.el >> > index 99f28cd20a..d2be3e737c 100644 >> > --- a/clojure-ts-mode.el >> > +++ b/clojure-ts-mode.el >> > @@ -54,7 +54,6 @@ >> > >> > ;;; Code: >> > (require 'treesit) >> > -(require 'lisp-mnt) >> > >> > (declare-function treesit-parser-create "treesit.c") >> > (declare-function treesit-node-eq "treesit.c") >> > @@ -71,8 +70,7 @@ >> > :link '(emacs-commentary-link :tag "Commentary" "clojure-mode")) >> > >> > (defconst clojure-ts-mode-version >> > - (eval-when-compile >> > - (lm-version (or load-file-name buffer-file-name))) >> > + "0.2.2" >> > "The current version of `clojure-ts-mode'.") >> > >> > (defcustom clojure-ts-comment-macro-font-lock-body nil >> > @@ -884,7 +882,10 @@ forms like deftype, defrecord, reify, proxy, etc." >> > (defun clojure-ts-mode-display-version () >> > "Display the current `clojure-mode-version' in the minibuffer." >> > (interactive) >> > - (message "clojure-ts-mode (version %s)" clojure-ts-mode-version)) >> > + (let ((pkg-version (package-get-version))) >> > + (if pkg-version >> > + (message "clojure-ts-mode %s (package: %s)" clojure-ts-mode-version pkg-version) >> > + (message "clojure-ts-mode %s" clojure-ts-mode-version)))) >> > >> > (defconst clojure-ts-grammar-recipes >> > '((clojure "https://github.com/sogaiu/tree-sitter-clojure.git" >> >> I don't understand the point of this change. If you duplicate the >> information of the package version anyway, then why use >> `package-get-version' at all? The only advantage this seems to bring is >> that if you forget to bump the version in `clojure-ts-mode-version' that >> you can find out about the discrepancy, but then it is too late and >> confusing. >> >> (Generally, I just don't think these kinds of "version information" >> commands are really useful anymore, at least since package management >> has become the widespread norm.) >> >> -- >> Philip Kaludercic on peregrine >> >> > [-- Attachment #2: Type: text/html, Size: 4498 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/clojure-ts-mode 649bf1120f: Improve the package version reporting 2024-06-04 9:46 ` Bozhidar Batsov 2024-06-04 9:49 ` Bozhidar Batsov @ 2024-06-04 10:54 ` Philip Kaludercic 2024-06-04 10:58 ` Bozhidar Batsov 1 sibling, 1 reply; 6+ messages in thread From: Philip Kaludercic @ 2024-06-04 10:54 UTC (permalink / raw) To: Bozhidar Batsov; +Cc: Emacs Devel "Bozhidar Batsov" <bozhidar@batsov.dev> writes: > I guess you having used MELPA, right? The package versions there are > replaced with a timestamp, so they are not very useful if they are not > complemented by the actual version. That's why for development > versions I'd like to see them both in the user reports. My understanding was that they appended the timestamp (in a decimal encoding) to the version string? Or is that information outdated? > On Tue, Jun 4, 2024, at 12:09 PM, Philip Kaludercic wrote: >> ELPA Syncer <elpasync@gnu.org> writes: >> >> > branch: elpa/clojure-ts-mode >> > commit 649bf1120f10250d464d4e9ad1905b481d2e504c >> > Author: Bozhidar Batsov <bozhidar@batsov.dev> >> > Commit: Bozhidar Batsov <bozhidar@batsov.dev> >> > >> > Improve the package version reporting >> > --- >> > clojure-ts-mode.el | 9 +++++---- >> > 1 file changed, 5 insertions(+), 4 deletions(-) >> > >> > diff --git a/clojure-ts-mode.el b/clojure-ts-mode.el >> > index 99f28cd20a..d2be3e737c 100644 >> > --- a/clojure-ts-mode.el >> > +++ b/clojure-ts-mode.el >> > @@ -54,7 +54,6 @@ >> > >> > ;;; Code: >> > (require 'treesit) >> > -(require 'lisp-mnt) >> > >> > (declare-function treesit-parser-create "treesit.c") >> > (declare-function treesit-node-eq "treesit.c") >> > @@ -71,8 +70,7 @@ >> > :link '(emacs-commentary-link :tag "Commentary" "clojure-mode")) >> > >> > (defconst clojure-ts-mode-version >> > - (eval-when-compile >> > - (lm-version (or load-file-name buffer-file-name))) >> > + "0.2.2" >> > "The current version of `clojure-ts-mode'.") >> > >> > (defcustom clojure-ts-comment-macro-font-lock-body nil >> > @@ -884,7 +882,10 @@ forms like deftype, defrecord, reify, proxy, etc." >> > (defun clojure-ts-mode-display-version () >> > "Display the current `clojure-mode-version' in the minibuffer." >> > (interactive) >> > - (message "clojure-ts-mode (version %s)" clojure-ts-mode-version)) >> > + (let ((pkg-version (package-get-version))) >> > + (if pkg-version >> > + (message "clojure-ts-mode %s (package: %s)" clojure-ts-mode-version pkg-version) >> > + (message "clojure-ts-mode %s" clojure-ts-mode-version)))) >> > >> > (defconst clojure-ts-grammar-recipes >> > '((clojure "https://github.com/sogaiu/tree-sitter-clojure.git" >> >> I don't understand the point of this change. If you duplicate the >> information of the package version anyway, then why use >> `package-get-version' at all? The only advantage this seems to bring is >> that if you forget to bump the version in `clojure-ts-mode-version' that >> you can find out about the discrepancy, but then it is too late and >> confusing. >> >> (Generally, I just don't think these kinds of "version information" >> commands are really useful anymore, at least since package management >> has become the widespread norm.) >> >> -- >> Philip Kaludercic on peregrine >> >> -- Philip Kaludercic on peregrine ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/clojure-ts-mode 649bf1120f: Improve the package version reporting 2024-06-04 10:54 ` Philip Kaludercic @ 2024-06-04 10:58 ` Bozhidar Batsov 2024-06-04 11:27 ` Philip Kaludercic 0 siblings, 1 reply; 6+ messages in thread From: Bozhidar Batsov @ 2024-06-04 10:58 UTC (permalink / raw) To: Philip Kaludercic; +Cc: Emacs Devel [-- Attachment #1: Type: text/plain, Size: 3239 bytes --] Pretty sure this was never the case. See the image below for details: On Tue, Jun 4, 2024, at 1:54 PM, Philip Kaludercic wrote: > "Bozhidar Batsov" <bozhidar@batsov.dev> writes: > > > I guess you having used MELPA, right? The package versions there are > > replaced with a timestamp, so they are not very useful if they are not > > complemented by the actual version. That's why for development > > versions I'd like to see them both in the user reports. > > My understanding was that they appended the timestamp (in a decimal > encoding) to the version string? Or is that information outdated? > > > On Tue, Jun 4, 2024, at 12:09 PM, Philip Kaludercic wrote: > >> ELPA Syncer <elpasync@gnu.org> writes: > >> > >> > branch: elpa/clojure-ts-mode > >> > commit 649bf1120f10250d464d4e9ad1905b481d2e504c > >> > Author: Bozhidar Batsov <bozhidar@batsov.dev> > >> > Commit: Bozhidar Batsov <bozhidar@batsov.dev> > >> > > >> > Improve the package version reporting > >> > --- > >> > clojure-ts-mode.el | 9 +++++---- > >> > 1 file changed, 5 insertions(+), 4 deletions(-) > >> > > >> > diff --git a/clojure-ts-mode.el b/clojure-ts-mode.el > >> > index 99f28cd20a..d2be3e737c 100644 > >> > --- a/clojure-ts-mode.el > >> > +++ b/clojure-ts-mode.el > >> > @@ -54,7 +54,6 @@ > >> > > >> > ;;; Code: > >> > (require 'treesit) > >> > -(require 'lisp-mnt) > >> > > >> > (declare-function treesit-parser-create "treesit.c") > >> > (declare-function treesit-node-eq "treesit.c") > >> > @@ -71,8 +70,7 @@ > >> > :link '(emacs-commentary-link :tag "Commentary" "clojure-mode")) > >> > > >> > (defconst clojure-ts-mode-version > >> > - (eval-when-compile > >> > - (lm-version (or load-file-name buffer-file-name))) > >> > + "0.2.2" > >> > "The current version of `clojure-ts-mode'.") > >> > > >> > (defcustom clojure-ts-comment-macro-font-lock-body nil > >> > @@ -884,7 +882,10 @@ forms like deftype, defrecord, reify, proxy, etc." > >> > (defun clojure-ts-mode-display-version () > >> > "Display the current `clojure-mode-version' in the minibuffer." > >> > (interactive) > >> > - (message "clojure-ts-mode (version %s)" clojure-ts-mode-version)) > >> > + (let ((pkg-version (package-get-version))) > >> > + (if pkg-version > >> > + (message "clojure-ts-mode %s (package: %s)" clojure-ts-mode-version pkg-version) > >> > + (message "clojure-ts-mode %s" clojure-ts-mode-version)))) > >> > > >> > (defconst clojure-ts-grammar-recipes > >> > '((clojure "https://github.com/sogaiu/tree-sitter-clojure.git" > >> > >> I don't understand the point of this change. If you duplicate the > >> information of the package version anyway, then why use > >> `package-get-version' at all? The only advantage this seems to bring is > >> that if you forget to bump the version in `clojure-ts-mode-version' that > >> you can find out about the discrepancy, but then it is too late and > >> confusing. > >> > >> (Generally, I just don't think these kinds of "version information" > >> commands are really useful anymore, at least since package management > >> has become the widespread norm.) > >> > >> -- > >> Philip Kaludercic on peregrine > >> > >> > > -- > Philip Kaludercic on peregrine > > [-- Attachment #2.1: Type: text/html, Size: 5832 bytes --] [-- Attachment #2.2: image.png --] [-- Type: image/png, Size: 246635 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/clojure-ts-mode 649bf1120f: Improve the package version reporting 2024-06-04 10:58 ` Bozhidar Batsov @ 2024-06-04 11:27 ` Philip Kaludercic 0 siblings, 0 replies; 6+ messages in thread From: Philip Kaludercic @ 2024-06-04 11:27 UTC (permalink / raw) To: Bozhidar Batsov; +Cc: Emacs Devel "Bozhidar Batsov" <bozhidar@batsov.dev> writes: > Pretty sure this was never the case. See the image below for details: That looks bad, but I guess if having the package on MELPA is a requirement, then this is the necessary price to pay :/ (Also, the information in that screenshot is just text, you could have just copied it into your message, then it would have been part of my response as well). > * > > On Tue, Jun 4, 2024, at 1:54 PM, Philip Kaludercic wrote: > > "Bozhidar Batsov" <bozhidar@batsov.dev> writes: > > > I guess you having used MELPA, right? The package versions there are > > replaced with a timestamp, so they are not very useful if they are not > > complemented by the actual version. That's why for development > > versions I'd like to see them both in the user reports. > > My understanding was that they appended the timestamp (in a decimal > encoding) to the version string? Or is that information outdated? > > > On Tue, Jun 4, 2024, at 12:09 PM, Philip Kaludercic wrote: > >> ELPA Syncer <elpasync@gnu.org> writes: > >> > >> > branch: elpa/clojure-ts-mode > >> > commit 649bf1120f10250d464d4e9ad1905b481d2e504c > >> > Author: Bozhidar Batsov <bozhidar@batsov.dev> > >> > Commit: Bozhidar Batsov <bozhidar@batsov.dev> > >> > > >> > Improve the package version reporting > >> > --- > >> > clojure-ts-mode.el | 9 +++++---- > >> > 1 file changed, 5 insertions(+), 4 deletions(-) > >> > > >> > diff --git a/clojure-ts-mode.el b/clojure-ts-mode.el > >> > index 99f28cd20a..d2be3e737c 100644 > >> > --- a/clojure-ts-mode.el > >> > +++ b/clojure-ts-mode.el > >> > @@ -54,7 +54,6 @@ > >> > > >> > ;;; Code: > >> > (require 'treesit) > >> > -(require 'lisp-mnt) > >> > > >> > (declare-function treesit-parser-create "treesit.c") > >> > (declare-function treesit-node-eq "treesit.c") > >> > @@ -71,8 +70,7 @@ > >> > :link '(emacs-commentary-link :tag "Commentary" "clojure-mode")) > >> > > >> > (defconst clojure-ts-mode-version > >> > - (eval-when-compile > >> > - (lm-version (or load-file-name buffer-file-name))) > >> > + "0.2.2" > >> > "The current version of `clojure-ts-mode'.") > >> > > >> > (defcustom clojure-ts-comment-macro-font-lock-body nil > >> > @@ -884,7 +882,10 @@ forms like deftype, defrecord, reify, proxy, etc." > >> > (defun clojure-ts-mode-display-version () > >> > "Display the current `clojure-mode-version' in the minibuffer." > >> > (interactive) > >> > - (message "clojure-ts-mode (version %s)" clojure-ts-mode-version)) > >> > + (let ((pkg-version (package-get-version))) > >> > + (if pkg-version > >> > + (message "clojure-ts-mode %s (package: %s)" clojure-ts-mode-version pkg-version) > >> > + (message "clojure-ts-mode %s" clojure-ts-mode-version)))) > >> > > >> > (defconst clojure-ts-grammar-recipes > >> > '((clojure "https://github.com/sogaiu/tree-sitter-clojure.git" > >> > >> I don't understand the point of this change. If you duplicate the > >> information of the package version anyway, then why use > >> `package-get-version' at all? The only advantage this seems to bring is > >> that if you forget to bump the version in `clojure-ts-mode-version' that > >> you can find out about the discrepancy, but then it is too late and > >> confusing. > >> > >> (Generally, I just don't think these kinds of "version information" > >> commands are really useful anymore, at least since package management > >> has become the widespread norm.) > >> > >> -- > >> Philip Kaludercic on peregrine > >> > >> > > -- > Philip Kaludercic on peregrine > -- Philip Kaludercic on peregrine ^ permalink raw reply [flat|nested] 6+ messages in thread
![[-- Attachment #2.2: image.png --] [-- Type: image/png, Size: 246635 bytes --]](../../a13450f3-feb1-4dec-a00e-4ca9034fb2ed@app.fastmail.com/2.2-image.png){kind=link}
end of thread, other threads:[~2024-06-04 11:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171748798553.6513.6711701045751855775@vcs2.savannah.gnu.org>
[not found] ` <20240604075945.DB087C1F9CB@vcs2.savannah.gnu.org>
2024-06-04 9:09 ` [nongnu] elpa/clojure-ts-mode 649bf1120f: Improve the package version reporting Philip Kaludercic
2024-06-04 9:46 ` Bozhidar Batsov
2024-06-04 9:49 ` Bozhidar Batsov
2024-06-04 10:54 ` Philip Kaludercic
2024-06-04 10:58 ` Bozhidar Batsov
2024-06-04 11:27 ` Philip Kaludercic
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).