From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: src/nsterm.m: fix window tabbing on macOS Date: Thu, 13 May 2021 15:46:54 +1000 Organization: By Dasein Message-ID: References: <9cdf9d6dc55ccd4894d758d3237b0be2@purelymail.com> <03FB7137-A02D-4B94-AF1F-8B7E84DEF5DB@bydasein.com> <39fa782b82e274d3e9c40e934df89d68@purelymail.com> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10874"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Purely Mail via Roundcube/1.4.10 Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 13 07:47:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lh4CO-0002ih-2F for ged-emacs-devel@m.gmane-mx.org; Thu, 13 May 2021 07:47:52 +0200 Original-Received: from localhost ([::1]:47896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lh4CN-00007s-4a for ged-emacs-devel@m.gmane-mx.org; Thu, 13 May 2021 01:47:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lh4Bk-0007t1-E5 for emacs-devel@gnu.org; Thu, 13 May 2021 01:47:12 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:46298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lh4Bg-0004iN-Ht for emacs-devel@gnu.org; Thu, 13 May 2021 01:47:12 -0400 DKIM-Signature: a=rsa-sha256; b=YGsXX79RV5nx3dBqXUit42RJEJH3hRgj0H6Q/vOjGJStuKNfRzsNfHF4Yxc73PHGwl3P4iii3/ORuTE1ST1bVujcRQTGuNbXkDUU7nctmfFEdDAsxKrg0OuzH543SiQtlHemj3Rpa2ej5gHzl6Ow9eGO/gX9peO4oK3W220fINC83xwqJ84idmQ8yQnFFVFX+qgoXVLHiPX81+fEMQMxmzrOOonf65hEoOIuAbBiYxxJkEBqoybIXeqnXKQLFgjWWe7CzAzU7UNfnDoUzbpka81NPuNqPy1Do/xq/WPp9w48oWjdD/G07FINqDwUrhcqUQbB62nv+YSFz7H3Vo39tg==; s=purelymail3; d=bydasein.com; v=1; bh=ISlu+bHaFshOXnTrsDUqkK4X7QMBs7rNBZUuRInwIT0=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=BgSCPdvaimWAlTBikkwQ+kOD88pJ5Hcw4nEckL+o5IjnEFXlodcNQo2ebb/ERP2KrCk5zHZ/UQU30wNvrGrc7t1+8Nlea5SDLuaFuq2mSbkGmpVDorO7RreQbHjBIrjnZWg/YtUiQWRR6JJ0X166x0dHsoFzWZdm0AOnrbcLGvgs63pYY0b1diiGm3ILTFS/FlnhfO5HU5ZRhqFmHF3da5qV8cI8BMI79di4SFMsJqZSfcpbpLyBHGfBGNSVfMCrxt47IxviiZkGwvhvDvHdEXZt1VLbB075Eg2uxjuwUTYW4rbB0LIaFAspscmzLbrOQAYKPlMFwxLNx464AgHKBg==; s=purelymail3; d=purelymail.com; v=1; bh=ISlu+bHaFshOXnTrsDUqkK4X7QMBs7rNBZUuRInwIT0=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by ip-172-30-0-124.ec2.internal (JAMES SMTP Server ) with ESMTPA ID -1186082879; Thu, 13 May 2021 05:46:54 +0000 (UTC) In-Reply-To: X-Sender: pwr@bydasein.com Received-SPF: pass client-ip=34.202.193.197; envelope-from=pwr@bydasein.com; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269230 Archived-At: On 2021-05-13 07:23, Alan Third wrote: >> You are correct. I only looked at the nextstep/README file today. >> >> Given that tabs look much a part of the macOS window system I >> think/hope a >> person's first assumption would be that it's an Apple thing and >> hopefully >> first burn out their ire on Apple forums/reddits/etc. Nevertheless, we >> shouldn't inhibit all for the failings of a few. > > Yes, I suppose we could put it in NEWS and hope that enough people see > it there to cover us in places like reddit. Agreed. People like reading about new features (or "features"). >> The only thing that's a little weird is that this tab bar is not >> visible >> when in full screen, requiring moving the mouse up to reveal it. It >> would >> clearer what's happening if the tab bar behaved more like Terminal.app >> when >> in full screen: opening more than a single tab keeps the tab bar >> visible (in >> full screen or windowed). > > Isn't that how all the window chrome works in fullscreen? Do we do > some special thing to hide the toolbar? Perhaps we should rethink that > (although enough people run in fullscreen all the time that I suspect > that change would be genuinely contentious). You're right and I can't find another macOS app with a tab bar that behaves the way Emacs.app does, so I gotta assume there is something somewhere overriding the Cocoa window manager behaviour. But I'm really only qualified to guess; I looked through nsterm.m and changed a few suspected BOOL values and recompiled a few times but nothing had an effect on the hidden tab bar. Relatedly, tool-bar-mode is in the same boat; hidden in full screen, but probably shouldn't be. > If you just remove it completely does it do anything different from > your patch? It appears that removing the code has the same effect as NSWindowTabbingModeAutomatic. I like minimalism so happy to just remove it.