From: "Paul W. Rankin" via "Emacs development discussions." <emacs-devel@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: emacs-devel@gnu.org
Subject: Re: src/nsterm.m: fix window tabbing on macOS
Date: Thu, 13 May 2021 15:46:54 +1000 [thread overview]
Message-ID: <a0ee7a8da3a90d0b85a912dda560be70@purelymail.com> (raw)
In-Reply-To: <YJxHZRrD5JHRbA5t@idiocy.org>
On 2021-05-13 07:23, Alan Third wrote:
>> You are correct. I only looked at the nextstep/README file today.
>>
>> Given that tabs look much a part of the macOS window system I
>> think/hope a
>> person's first assumption would be that it's an Apple thing and
>> hopefully
>> first burn out their ire on Apple forums/reddits/etc. Nevertheless, we
>> shouldn't inhibit all for the failings of a few.
>
> Yes, I suppose we could put it in NEWS and hope that enough people see
> it there to cover us in places like reddit.
Agreed. People like reading about new features (or "features").
>> The only thing that's a little weird is that this tab bar is not
>> visible
>> when in full screen, requiring moving the mouse up to reveal it. It
>> would
>> clearer what's happening if the tab bar behaved more like Terminal.app
>> when
>> in full screen: opening more than a single tab keeps the tab bar
>> visible (in
>> full screen or windowed).
>
> Isn't that how all the window chrome works in fullscreen? Do we do
> some special thing to hide the toolbar? Perhaps we should rethink that
> (although enough people run in fullscreen all the time that I suspect
> that change would be genuinely contentious).
You're right and I can't find another macOS app with a tab bar that
behaves the way Emacs.app does, so I gotta assume there is something
somewhere overriding the Cocoa window manager behaviour. But I'm really
only qualified to guess; I looked through nsterm.m and changed a few
suspected BOOL values and recompiled a few times but nothing had an
effect on the hidden tab bar.
Relatedly, tool-bar-mode is in the same boat; hidden in full screen, but
probably shouldn't be.
> If you just remove it completely does it do anything different from
> your patch?
It appears that removing the code has the same effect as
NSWindowTabbingModeAutomatic. I like minimalism so happy to just remove
it.
next prev parent reply other threads:[~2021-05-13 5:46 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 9:26 src/nsterm.m: fix window tabbing on macOS Paul W. Rankin via Emacs development discussions.
2021-05-08 11:21 ` Alan Third
2021-05-08 12:27 ` Paul W. Rankin via Emacs development discussions.
2021-05-08 12:35 ` Paul W. Rankin via Emacs development discussions.
2021-05-10 19:53 ` Alan Third
2021-05-11 5:45 ` Paul W. Rankin via Emacs development discussions.
2021-05-11 19:20 ` chad
2021-05-12 9:47 ` Paul W. Rankin via Emacs development discussions.
2021-05-12 21:23 ` Alan Third
2021-05-13 5:46 ` Paul W. Rankin via Emacs development discussions. [this message]
2021-05-13 21:05 ` Alan Third
2021-05-16 9:16 ` Paul W. Rankin via Emacs development discussions.
2021-05-26 19:56 ` Alan Third
2021-05-27 11:06 ` Andrii Kolomoiets
2021-05-28 8:26 ` martin rudalics
2021-05-28 8:28 ` Paul W. Rankin via Emacs development discussions.
2021-05-28 8:36 ` martin rudalics
2021-05-28 8:54 ` Alan Third
2021-06-06 4:09 ` Paul W. Rankin via Emacs development discussions.
2021-06-06 7:43 ` martin rudalics
2021-05-28 9:07 ` Andrii Kolomoiets
2021-05-28 9:21 ` martin rudalics
2021-05-28 9:37 ` Paul W. Rankin via Emacs development discussions.
2021-05-28 9:51 ` martin rudalics
2021-05-28 14:33 ` Paul W. Rankin via Emacs development discussions.
2021-05-28 20:52 ` Andrii Kolomoiets
2021-06-05 20:58 ` Alan Third
2021-06-06 4:01 ` Paul W. Rankin via Emacs development discussions.
2021-06-06 6:14 ` Eli Zaretskii
2021-06-06 6:48 ` Paul W. Rankin via Emacs development discussions.
2021-06-06 9:13 ` Alan Third
[not found] ` <8CCF969D-32AF-4542-8838-21DF4AA45523@yasufuku.dev>
2021-06-06 11:36 ` Alan Third
2021-06-06 12:19 ` Paul W. Rankin via Emacs development discussions.
2021-06-06 18:56 ` Alan Third
2021-06-07 0:27 ` Paul W. Rankin via Emacs development discussions.
2021-06-07 22:13 ` Alan Third
2021-06-08 7:32 ` Paul W. Rankin via Emacs development discussions.
2021-06-08 8:59 ` Eli Zaretskii
2021-06-09 8:35 ` martin rudalics
2021-06-09 8:48 ` Alan Third
2021-06-09 12:20 ` martin rudalics
2021-06-09 12:29 ` Alan Third
[not found] <65f1-60bcfd80-157-23301c40@168015757>
2021-06-07 0:11 ` Paul W. Rankin via Emacs development discussions.
2021-06-07 21:57 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0ee7a8da3a90d0b85a912dda560be70@purelymail.com \
--to=emacs-devel@gnu.org \
--cc=alan@idiocy.org \
--cc=pwr@bydasein.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).