From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 3698c4e: * cl-generic.el (cl-defmethod): Make docstring dynamic Date: Mon, 1 Aug 2016 17:02:08 -0400 Message-ID: References: <20160712160406.32314.27649@vcs.savannah.gnu.org> <20160712160406.974D5220147@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1470085376 7475 195.159.176.226 (1 Aug 2016 21:02:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 Aug 2016 21:02:56 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 To: emacs-devel@gnu.org, Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 01 23:02:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUKMO-0001iS-97 for ged-emacs-devel@m.gmane.org; Mon, 01 Aug 2016 23:02:52 +0200 Original-Received: from localhost ([::1]:52813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUKMK-0007VU-T3 for ged-emacs-devel@m.gmane.org; Mon, 01 Aug 2016 17:02:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUKLm-0007VP-LF for emacs-devel@gnu.org; Mon, 01 Aug 2016 17:02:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUKLh-0000k8-L1 for emacs-devel@gnu.org; Mon, 01 Aug 2016 17:02:13 -0400 Original-Received: from limerock01.mail.cornell.edu ([128.84.13.241]:47823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUKLh-0000k2-GF for emacs-devel@gnu.org; Mon, 01 Aug 2016 17:02:09 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u71L27xd012022; Mon, 1 Aug 2016 17:02:08 -0400 Original-Received: from [192.168.1.9] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u71L26WG027188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 1 Aug 2016 17:02:07 -0400 In-Reply-To: <20160712160406.974D5220147@vcs.savannah.gnu.org> X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.84.13.241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206330 Archived-At: On 7/12/2016 12:04 PM, Stefan Monnier wrote: > branch: master > commit 3698c4e475fb59730626af5d001599785ef5ef9e > Author: Stefan Monnier > Commit: Stefan Monnier > > * cl-generic.el (cl-defmethod): Make docstring dynamic > > * lisp/emacs-lisp/cl-generic.el (cl-defmethod): Make docstring dynamic. > (cl--generic-make-defmethod-docstring): New function for that. > (cl-defmethod, cl-generic-generalizers): Tweak docstrings accordingly. > (cl-generic-define-method, cl--generic-describe): Change `load-history' > format of cl-defmethods, so as not to confused methods with equal > specializers but different qualifiers. > * lisp/emacs-lisp/eieio-core.el (cl-generic-generalizers): Provide docstrings. I'm getting five test failures in elisp-mode-tests: FAILED xref-elisp-test-find-defs-defgeneric-co-located-default FAILED xref-elisp-test-find-defs-defgeneric-el FAILED xref-elisp-test-find-defs-defgeneric-implicit-generic FAILED xref-elisp-test-find-defs-defgeneric-no-default FAILED xref-elisp-test-find-defs-defgeneric-separate-default A bisection points to this commit as the culprit. Ken