From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Patch upstream Git for Elisp diff hunk headings
Date: Thu, 11 Feb 2021 14:13:45 -0500 [thread overview]
Message-ID: <a027c233-455a-0f16-945f-75d88417e8e0@gmail.com> (raw)
In-Reply-To: <CAOkDyE_HFTnGz2mcKs7zVzrB3Y2smOyQJfMMV_HtZX_uFOAgKQ@mail.gmail.com>
On 2/11/21 1:27 PM, Adam Spiers wrote:
> While of course no one is claiming that this is technically correct in
> all cases, I don't think I can actually recall ever seeing a single
> instance of a top-level form which *was* indented.
This heuristic is going to break for `eval-and-compile` forms, which are reasonably common.
Maybe combine both heuristics and detect both `(def` at any indentation and `(` in column 0?
next prev parent reply other threads:[~2021-02-11 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 14:42 Patch upstream Git for Elisp diff hunk headings Protesilaos Stavrou
2021-02-11 18:27 ` Adam Spiers
2021-02-11 19:05 ` Stefan Kangas
2021-02-12 17:39 ` Basil L. Contovounesios
2021-02-11 19:13 ` Clément Pit-Claudel [this message]
2021-02-11 19:15 ` Óscar Fuentes
2021-02-11 19:38 ` Stefan Monnier
2021-02-13 19:35 ` Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a027c233-455a-0f16-945f-75d88417e8e0@gmail.com \
--to=cpitclaudel@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).