From: Pip Cet <pipcet@protonmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gerd.moellmann@gmail.com, yantar92@posteo.net,
monnier@iro.umontreal.ca, emacs-devel@gnu.org,
eller.helmut@gmail.com
Subject: Re: MPS: dangling markers
Date: Mon, 01 Jul 2024 21:08:07 +0000 [thread overview]
Message-ID: <_nyaStUr9UjwGJZ-bqaGNyxgCMuh-bglMdWw2rpGNja9pdNct6lfF2QXthIQFfjn2-n-T3R4WCuHMLdmIuoRzzAfuHrw0Q1rq3V-5oFLzDE=@protonmail.com> (raw)
In-Reply-To: <868qyldjqi.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On Monday, July 1st, 2024 at 18:56, Eli Zaretskii <eliz@gnu.org> wrote:
> The 32-bit build of the branch is now broken: dumping dies with
Sorry, it took me a while to reproduce this because the default build worked fine, I had to --enable-checking to get something like your error, though in my case it was clearly the set_weak_hash_hash_value call that was to blame.
I incorrectly assumed sxhash, Fsxhash, and the hash value in an equal-based hash table were all the same number; in reality, sxhash is 32 bits on a 32-bit system, 64 bits on a 64-bit system, Fsxhash is 30 bits on a 32-bit system, 62 bits on a 64-bit system, and the hash value is 32 bits on all systems.
Long story short, would you be able to try this patch and see whether you get a clean dump? I do here...
diff --git a/src/lisp.h b/src/lisp.h
index 0f5a5410081..75146bd7715 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -2997,7 +2997,7 @@ SXHASH_REDUCE (EMACS_UINT x)
reduce_emacs_uint_to_hash_hash (EMACS_UINT x)
{
verify (sizeof x <= 2 * sizeof (hash_hash_t));
- return (sizeof x == sizeof (hash_hash_t)
+ return 0x1fffffff & (sizeof x == sizeof (hash_hash_t)
? x
: x ^ (x >> (8 * (sizeof x - sizeof (hash_hash_t)))));
}
Obviously that's not a permanent fix.
Thanks
Pip
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0004-mps-weak-hash-tables.patch --]
[-- Type: text/x-patch; name=0004-mps-weak-hash-tables.patch, Size: 431 bytes --]
diff --git a/src/lisp.h b/src/lisp.h
index 0f5a5410081..75146bd7715 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -2997,7 +2997,7 @@ SXHASH_REDUCE (EMACS_UINT x)
reduce_emacs_uint_to_hash_hash (EMACS_UINT x)
{
verify (sizeof x <= 2 * sizeof (hash_hash_t));
- return (sizeof x == sizeof (hash_hash_t)
+ return 0x1fffffff & (sizeof x == sizeof (hash_hash_t)
? x
: x ^ (x >> (8 * (sizeof x - sizeof (hash_hash_t)))));
}
next prev parent reply other threads:[~2024-07-01 21:08 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 21:01 MPS: dangling markers Ihor Radchenko
2024-06-27 21:24 ` Stefan Monnier
2024-06-28 4:14 ` Gerd Möllmann
2024-06-28 16:37 ` Ihor Radchenko
2024-06-28 16:47 ` Gerd Möllmann
2024-06-28 16:52 ` Ihor Radchenko
2024-06-28 16:56 ` Gerd Möllmann
2024-06-28 17:18 ` Ihor Radchenko
2024-06-28 17:44 ` Gerd Möllmann
2024-06-29 3:57 ` Gerd Möllmann
2024-06-29 14:34 ` Ihor Radchenko
2024-06-29 14:56 ` Gerd Möllmann
2024-06-29 16:29 ` Eli Zaretskii
2024-06-29 17:09 ` Gerd Möllmann
2024-06-29 17:17 ` Gerd Möllmann
2024-06-29 17:23 ` Eli Zaretskii
2024-06-29 18:02 ` Gerd Möllmann
2024-06-29 18:11 ` Eli Zaretskii
2024-06-29 18:19 ` Gerd Möllmann
2024-06-29 19:51 ` Ihor Radchenko
2024-06-29 21:50 ` Gerd Möllmann
2024-06-29 22:33 ` Pip Cet
2024-06-30 4:41 ` Gerd Möllmann
2024-06-30 6:56 ` Gerd Möllmann
2024-06-30 9:51 ` Pip Cet
2024-06-30 11:02 ` Gerd Möllmann
2024-06-30 12:54 ` Pip Cet
2024-06-30 13:15 ` Gerd Möllmann
2024-06-30 19:02 ` Pip Cet
2024-06-30 19:22 ` Gerd Möllmann
2024-06-30 20:15 ` Pip Cet
2024-07-01 4:22 ` Gerd Möllmann
2024-07-01 17:14 ` Pip Cet
2024-07-01 18:20 ` Gerd Möllmann
2024-07-01 18:50 ` Eli Zaretskii
2024-07-01 19:04 ` Pip Cet
2024-07-01 19:07 ` Eli Zaretskii
2024-07-01 19:43 ` Gerd Möllmann
2024-07-01 18:56 ` Eli Zaretskii
2024-07-01 21:08 ` Pip Cet [this message]
2024-07-02 11:25 ` Eli Zaretskii
2024-07-03 18:46 ` Pip Cet
2024-07-03 19:20 ` Eli Zaretskii
2024-06-29 22:59 ` Stefan Monnier
2024-06-30 5:02 ` Gerd Möllmann
2024-06-30 5:29 ` Eli Zaretskii
2024-06-30 15:04 ` Stefan Monnier
2024-06-30 5:11 ` Eli Zaretskii
2024-06-30 4:57 ` Eli Zaretskii
2024-06-30 5:36 ` Gerd Möllmann
2024-06-30 12:25 ` Ihor Radchenko
2024-06-29 17:19 ` Ihor Radchenko
2024-06-29 18:05 ` Gerd Möllmann
2024-06-29 18:10 ` Eli Zaretskii
2024-06-29 18:17 ` Gerd Möllmann
2024-06-29 18:28 ` Ihor Radchenko
2024-06-29 17:20 ` Eli Zaretskii
2024-06-29 18:04 ` Gerd Möllmann
2024-06-29 17:16 ` Stefan Monnier
2024-06-29 18:12 ` Gerd Möllmann
2024-06-29 18:30 ` Stefan Monnier
2024-06-29 18:52 ` Gerd Möllmann
2024-06-29 21:20 ` Gerd Möllmann
2024-06-29 21:38 ` Gerd Möllmann
2024-06-30 7:11 ` Gerd Möllmann
2024-06-30 7:27 ` Gerd Möllmann
2024-06-30 7:45 ` Ihor Radchenko
2024-06-30 10:44 ` Gerd Möllmann
2024-06-30 11:23 ` Ihor Radchenko
2024-06-30 11:25 ` Gerd Möllmann
2024-06-30 11:31 ` Ihor Radchenko
2024-06-30 12:13 ` Gerd Möllmann
2024-06-30 12:18 ` Ihor Radchenko
2024-06-30 12:17 ` Ihor Radchenko
2024-06-30 12:28 ` Gerd Möllmann
2024-06-30 12:38 ` Ihor Radchenko
2024-06-30 12:48 ` Gerd Möllmann
2024-06-30 15:21 ` Ihor Radchenko
2024-06-30 15:32 ` Gerd Möllmann
2024-06-30 12:49 ` Eli Zaretskii
2024-06-29 15:17 ` Ihor Radchenko
2024-06-28 4:07 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='_nyaStUr9UjwGJZ-bqaGNyxgCMuh-bglMdWw2rpGNja9pdNct6lfF2QXthIQFfjn2-n-T3R4WCuHMLdmIuoRzzAfuHrw0Q1rq3V-5oFLzDE=@protonmail.com' \
--to=pipcet@protonmail.com \
--cc=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).