From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: c-post-command Date: Mon, 28 Oct 2024 16:05:07 +0000 Message-ID: References: <0b46e919-da81-4153-b27c-dbd46f5b12f0@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21121"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 28 17:06:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t5SG7-0005MH-8V for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Oct 2024 17:06:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5SFE-0002xx-NM; Mon, 28 Oct 2024 12:05:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5SF5-0002xS-0R for emacs-devel@gnu.org; Mon, 28 Oct 2024 12:05:20 -0400 Original-Received: from mail.muc.de ([193.149.48.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5SF0-0005d7-PL for emacs-devel@gnu.org; Mon, 28 Oct 2024 12:05:17 -0400 Original-Received: (qmail 92963 invoked by uid 3782); 28 Oct 2024 17:05:08 +0100 Original-Received: from muc.de (p4fe15284.dip0.t-ipconnect.de [79.225.82.132]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 28 Oct 2024 17:05:08 +0100 Original-Received: (qmail 10915 invoked by uid 1000); 28 Oct 2024 16:05:07 -0000 Content-Disposition: inline In-Reply-To: <0b46e919-da81-4153-b27c-dbd46f5b12f0@gmx.at> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.3; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324898 Archived-At: Hello, Martin. On Sun, Oct 27, 2024 at 10:25:07 +0100, martin rudalics wrote: > After setting the major mode of a buffer to 'c-mode' and switching to a > buffer in 'text-mode', the value of 'post-command-hook' in that buffer > includes 'c-post-command'. I suppose this comes from > (add-hook 'post-command-hook 'c-post-command) > in 'c-basic-common-init' which is removed via > (remove-hook 'post-command-hook 'c-post-command) Yes. > in 'change-major-mode-hook' that calls 'c-leave-cc-mode-mode'. But such > "removals" happen only when changing the major mode of a buffer and not > when simply switching buffers. Even if 'c-post-command' returns > immediately when not in a 'c-mode' buffer, it is disconcerting to see > that function in ‘post-command-hook’ when working in some other mode. > Is there any reason not to use > (add-hook 'post-command-hook 'c-post-command nil t) No reason at all! I don't know why I didn't do that when I introduced c-post-command. > in 'c-basic-common-init'? > As an aside, 'c-leave-cc-mode-mode' also does > (remove-hook 'post-gc-hook 'c-post-gc-hook))) > which I see nowhere added before. How did you spot that? :-) c-post-gc-hook existed for a short while back in 2021, but I obviously failed to remove it properly. I've now fixed all these things, and committed the fix to the Emacs master branch. Thanks! > martin -- Alan Mackenzie (Nuremberg, Germany).