The fixing of bug#73182 - the indentation of enum structures in CC Mode

The fixing of bug#73182 - the indentation of enum structures in CC Mode

[Alan Mackenzie]

Hello, Emacs.

In CC Mode, I've taken the liberty of fixing the indentation of enum
structures, so that (at least in "gnu" style) this indentation matches
the GNU coding standards.  This is bug#73182.

The reasons for this are several:
(i) c-ts-mode and friends indent this way anyhow, so it will lead to
  more consistency.
(ii) The enums in the Emacs sources are inconsistent anyhow, with around
  35% of them "standard" and the other 65% the old CC Mode way.
(iii) The decision I took in 2014 not to fix this indentation, so as not
  to introduce a chaotic mix of indentations, was mistaken.  Even then,
  this chaos already existed.

Just to be explicit, the "old CC Mode way" indented an enum as:

enum double
  {
    ONE,
    TWO
  };

, and the GNU standard way looks like:

enum double
{
  ONE,
  TWO
};

..

I have committed this change to master.  I haven't yet written a NEWS
entry, which I intend to do tomorrow.

For anybody who still wants the old CC Mode way, I suggest one of the
following:
(i) In a CC Mode buffer, put point on an enum's opening brace, and do
  C-c C-o.  Accept the default, and as the new value, type in
  "brace-list-open" (without the quotes).
(ii) In an appropriate place (late) in your .emacs/init.el, insert the
  following:
      (c-set-offset 'enum-open 'brace-list-open)
  .
(iii) Create/edit a CC Mode style so that there is an entry in the
  c-offsets-alist alist:
      (enum-open . brace-list-open)
  .

The above uses a new CC Mode feature, that of having a syntactic symbol
as the cdr of a c-offsets-alist entry.  Full instructions can be found
in the CC Mode manual (which has also been updated).

I suggest that we do NOT immediately "correct" the indentation of the
65% of enums.  Rather, we should fix them gradually, at the same time as
other changes get made to them, much the way we amend the indentation of
our code by tabs/spaces.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: The fixing of bug#73182 - the indentation of enum structures in CC Mode

[tomas]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

On Tue, Sep 24, 2024 at 09:41:42PM +0000, Alan Mackenzie wrote:
> Hello, Emacs.
> 
> In CC Mode, I've taken the liberty of fixing the indentation of enum
> structures, so that (at least in "gnu" style) this indentation matches
> the GNU coding standards.  This is bug#73182.

You've made at leas one happy -- thanks :-)

Cheers
-- 
t

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]