From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christopher Howard Newsgroups: gmane.emacs.devel Subject: Re: shell-command-sentinel hook? Date: Wed, 6 Mar 2024 07:39:43 -0900 Message-ID: References: <868r2xn4k3.fsf@gnu.org> <87r0goasnv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26287"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Suhail Singh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 06 17:40:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhuK6-0006hL-Ov for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Mar 2024 17:40:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhuJN-0002Pz-Ue; Wed, 06 Mar 2024 11:40:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhuJL-0002Pn-Iq for emacs-devel@gnu.org; Wed, 06 Mar 2024 11:40:07 -0500 Original-Received: from mx.kolabnow.com ([212.103.80.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhuJH-0001Ro-3D; Wed, 06 Mar 2024 11:40:07 -0500 Original-Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 3F5382095C31; Wed, 6 Mar 2024 17:39:51 +0100 (CET) Authentication-Results: ext-mx-out011.mykolab.com (amavis); dkim=pass (4096-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received:received; s=dkim20160331; t= 1709743188; x=1711557589; bh=tTyyyq/IXAfh8RUSSn4+HFPhr6SjPZ/QgoW LgafUWT4=; b=xT5ys4sD4knhJh8RxonGAaIQ8qIGUAeX24OdsyARybBcX7ZF2y/ usr9rul3KNGXCjChilSFID7cz2/YW9jrW1Ym2UHOBZYZm6PB5wwf/8OeH5LJbUnL AVE7B670bOB2lIU1d7vcYdQ1nmarXlk2hg7N6GvX59HaZpl/ltQr/jgLXUQVDnRd S2o/QKiHBSulMrFuXB8iulTCvRwEURGHtuFO6+MVY5GiFkuwp7ptphKz6UO43WmU xIs0Lq2ue38lNSKCTq1f4PUOpl9A4VAQNEmZjdbMjcYrVtEef4E4WCuN4I31W0So TH20LcO1sp466V+VpGLnG2VfOGoNTjHRn3frT3pY2Rf/egmDGIksDoNFNNCZCG09 R39eKNOodp5TwXwoc6nLxoAiHPgxJc07rp9QtC7L9fHprMZn5+so8E2LNUBydQpJ YF2fwRdU5v0DrdWHvo/Vg5ZtKk9hltJxOUg9BI6e2lEqAdUnab3xKHbCEefRznkU V61ZEvGWDYO7LaA338QyIfai4jC9IGLPe0hI0H3g9GGI9ICVVtU X-Virus-Scanned: amavis at mykolab.com Original-Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out011.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id UO3TLwHuOv0z; Wed, 6 Mar 2024 17:39:48 +0100 (CET) Original-Received: from int-mx009.mykolab.com (unknown [10.9.13.9]) by mx.kolabnow.com (Postfix) with ESMTPS id 73C8E2095C21; Wed, 6 Mar 2024 17:39:47 +0100 (CET) Original-Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx009.mykolab.com (Postfix) with ESMTPS id 391E820CB73B; Wed, 6 Mar 2024 17:39:47 +0100 (CET) Content-Disposition: inline In-Reply-To: <87r0goasnv.fsf@gmail.com> Autocrypt: addr=christopher@librehacker.com; prefer-encrypt=mutual; keydata= mDMEZEqk5BYJKwYBBAHaRw8BAQdAE/Dh4NUrMO5mxlZwV1H0X6DKaISWC/G5ws7voqpK6Xa0MEN ocmlzdG9waGVyIEhvd2FyZCA8Y2hyaXN0b3BoZXJAbGlicmVoYWNrZXIuY29tPoiQBBMWCAA4Fi EEMeL/OZnSMyOqPiAnGsX8bo2P8gwFAmRKpOQCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AAC gkQGsX8bo2P8gxyYgEA/ioHjyd0Bm3+YyW/vOLJZkDg1xx//zN9803Oayahz/gBAKwtHu69sqFZ /upw6mmyeP7ZndriTijMBZwfzcqDQWIMuDgEZEqk5RIKKwYBBAGXVQEFAQEHQO2aMfukvGwfyK7 f6DUkayD6h+RO+n6LGg0c0StFhF1CAwEIB4h4BBgWCAAgFiEEMeL/OZnSMyOqPiAnGsX8bo2P8g wFAmRKpOUCGwwACgkQGsX8bo2P8gxD6AEAncJh7NhGGBlNG43b5rMeeyrYVewJirj4hk2qk1iL3 KgA/301OIl9HuuM1hBLPOSTftjwKJUWDbzBFqbyGUFWaCUB Received-SPF: none client-ip=212.103.80.155; envelope-from=christopher@librehacker.com; helo=mx.kolabnow.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316860 Archived-At: Okay, thank you. I already implemented the override function, following the previous advice, but that sounds like a good idea as well. {http://gem.librehacker.com/gemlog/starlog/20240304-0.gmi} On Tue, Mar 05, 2024 at 11:30:28PM -0500, Suhail Singh wrote: > An :after advice would obviate that, unless I'm mistaken. Not to imply > that a hook may not still be helpful, but IIUC the code duplication > isn't necessary. -- Christopher Howard