From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christopher Howard Newsgroups: gmane.emacs.devel Subject: Re: shell-command-sentinel hook? Date: Mon, 4 Mar 2024 11:35:53 -0900 Message-ID: References: <868r2xn4k3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24064"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 04 21:37:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhF3T-00060L-Nk for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Mar 2024 21:36:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhF2f-0003kb-GD; Mon, 04 Mar 2024 15:36:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhF2c-0003jc-Tn for emacs-devel@gnu.org; Mon, 04 Mar 2024 15:36:06 -0500 Original-Received: from mx.kolabnow.com ([212.103.80.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhF2Y-0008WO-SA; Mon, 04 Mar 2024 15:36:06 -0500 Original-Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id A847B2095C06; Mon, 4 Mar 2024 21:35:58 +0100 (CET) Authentication-Results: ext-mx-out011.mykolab.com (amavis); dkim=pass (4096-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received:received; s=dkim20160331; t= 1709584558; x=1711398959; bh=+Wj8ixOzMhYK4YYJyV6nCwIC3uYhXhutIX0 BeX2mf9s=; b=47OpGsX7hz2nKLRCakOqmleel6aE+5jffXpy4SueUrBR+heagI3 FwbABZCYCp4XeGAuwfRsfoS93cVxDuognPMUpTSJSwQU6Na8mLeslKSsqLLBUQtG eQSkHYV4ogE5E3x7+ry+1goVMX6GYJAqyDM5ndDkg8c14/83evJa7nMFmo9VfzAi EmJMSMZTfeWP7mFNoHdp0xbm78ILDfe0kmxVohw8FaO6osScboPeKAfv8gnLZWrv kKVvD/HL/xv1Oee+LCBSsEOamHRd+JuNIJMUHB3WM2Lt4uGtEC5MYZd1hSKqkVVh idsy3ARYP3FzEhy1WZ4D99A3xL/EYJmBcC261jckDFBz4AjvCGphHjcW9bzMzfWN UjBQZQeTaZjZSzbNNUQ+odtIQUWFDuR8xHBXuwMUEzmDwJVkOov6fb/lwAziVyN/ kH9sE1PWy7jKyHqgZ2ZhuabJ98dfsr2haKKLEO0PccsTi3kmT4yBV5tLtIasTpf0 /7a0dX9gJHH9MlG8Sl5J6OWkS335HMdR+8FRU41QLQqvOFI5KPG X-Virus-Scanned: amavis at mykolab.com Original-Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out011.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id outH-hZTv6Ws; Mon, 4 Mar 2024 21:35:58 +0100 (CET) Original-Received: from int-mx009.mykolab.com (unknown [10.9.13.9]) by mx.kolabnow.com (Postfix) with ESMTPS id D654920AB2FA; Mon, 4 Mar 2024 21:35:57 +0100 (CET) Original-Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx009.mykolab.com (Postfix) with ESMTPS id 96EF220CA5F6; Mon, 4 Mar 2024 21:35:57 +0100 (CET) Content-Disposition: inline In-Reply-To: <868r2xn4k3.fsf@gnu.org> Autocrypt: addr=christopher@librehacker.com; prefer-encrypt=mutual; keydata= mDMEZEqk5BYJKwYBBAHaRw8BAQdAE/Dh4NUrMO5mxlZwV1H0X6DKaISWC/G5ws7voqpK6Xa0MEN ocmlzdG9waGVyIEhvd2FyZCA8Y2hyaXN0b3BoZXJAbGlicmVoYWNrZXIuY29tPoiQBBMWCAA4Fi EEMeL/OZnSMyOqPiAnGsX8bo2P8gwFAmRKpOQCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AAC gkQGsX8bo2P8gxyYgEA/ioHjyd0Bm3+YyW/vOLJZkDg1xx//zN9803Oayahz/gBAKwtHu69sqFZ /upw6mmyeP7ZndriTijMBZwfzcqDQWIMuDgEZEqk5RIKKwYBBAGXVQEFAQEHQO2aMfukvGwfyK7 f6DUkayD6h+RO+n6LGg0c0StFhF1CAwEIB4h4BBgWCAAgFiEEMeL/OZnSMyOqPiAnGsX8bo2P8g wFAmRKpOUCGwwACgkQGsX8bo2P8gxD6AEAncJh7NhGGBlNG43b5rMeeyrYVewJirj4hk2qk1iL3 KgA/301OIl9HuuM1hBLPOSTftjwKJUWDbzBFqbyGUFWaCUB Received-SPF: none client-ip=212.103.80.155; envelope-from=christopher@librehacker.com; helo=mx.kolabnow.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316812 Archived-At: On Mon, Mar 04, 2024 at 10:08:12PM +0200, Eli Zaretskii wrote: > Why cannot you simply override shell-command-sentinel with your own > function? Hi, I think I might end up doing that on my install. But, as an emacs-devel proposal, I thought it would be more useful in-general to have it available in an actual hook. (Hooks are great!) Since I cannot simply wrap shell-command-sentinel (it does not return the message and signal) my overide would need to reproduce the initial part of the function... ``` elisp (when (memq (process-status process) '(exit signal)) (shell-command-set-point-after-cmd (process-buffer process)) ...etc... ``` That might break in the next emacs release if you guys change any of those functions (memq, shell-command-set-point-after-cmd, etc.) or if you guys replace the sentinel with something else. -- Christopher Howard