* Native compilation unit tests failing since last weekend or so
@ 2023-10-27 19:10 Jens Schmidt
2023-10-27 21:29 ` Alan Mackenzie
2023-10-30 20:24 ` Jens Schmidt
0 siblings, 2 replies; 6+ messages in thread
From: Jens Schmidt @ 2023-10-27 19:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Andrea Corallo
I have been hoping these would go away ... on GNU/Linux, emacs-master,
with "-C --with-native-compilation --with-mailutils", after make
bootstrap:
SUMMARY OF TEST RESULTS
-----------------------
Files examined: 498
Ran 7568 tests, 7303 results as expected, 43 unexpected, 222 skipped
3 files contained unexpected results:
src/comp-tests.log
lisp/emacs-lisp/comp-cstr-tests.log
lisp/emacs-lisp/bytecomp-tests.log
Am I the only one seeing this?
Please let me know if you need more information on that.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Native compilation unit tests failing since last weekend or so
2023-10-27 19:10 Native compilation unit tests failing since last weekend or so Jens Schmidt
@ 2023-10-27 21:29 ` Alan Mackenzie
2023-10-30 20:24 ` Jens Schmidt
1 sibling, 0 replies; 6+ messages in thread
From: Alan Mackenzie @ 2023-10-27 21:29 UTC (permalink / raw)
To: Jens Schmidt; +Cc: emacs-devel, Andrea Corallo
Hello, Jens.
On Fri, Oct 27, 2023 at 21:10:38 +0200, Jens Schmidt wrote:
> I have been hoping these would go away ... on GNU/Linux, emacs-master,
> with "-C --with-native-compilation --with-mailutils", after make
> bootstrap:
Same here: I've been patiently waiting for them to get fixed, but
without taking the trouble to report them. ;-(
> SUMMARY OF TEST RESULTS
> -----------------------
> Files examined: 498
> Ran 7568 tests, 7303 results as expected, 43 unexpected, 222 skipped
> 3 files contained unexpected results:
> src/comp-tests.log
> lisp/emacs-lisp/comp-cstr-tests.log
> lisp/emacs-lisp/bytecomp-tests.log
> Am I the only one seeing this?
No, I see these, too. Exactly 43 successes.
They seem mainly to be due to "fixnum" and "integer" getting confused in
some fashion, and things like that.
> Please let me know if you need more information on that.
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Native compilation unit tests failing since last weekend or so
2023-10-27 19:10 Native compilation unit tests failing since last weekend or so Jens Schmidt
2023-10-27 21:29 ` Alan Mackenzie
@ 2023-10-30 20:24 ` Jens Schmidt
2023-11-01 8:21 ` Andrea Corallo
2023-11-03 20:25 ` bytecomp-tests still failing after Mattias' commit a3db503351e9 Jens Schmidt
1 sibling, 2 replies; 6+ messages in thread
From: Jens Schmidt @ 2023-10-30 20:24 UTC (permalink / raw)
To: emacs-devel; +Cc: Mattias Engdegård
On 2023-10-27 21:10, Jens Schmidt wrote:
> I have been hoping these would go away ... on GNU/Linux, emacs-master,
> with "-C --with-native-compilation --with-mailutils", after make
> bootstrap:
This got much better (thanks), I'm down to one failing unit test now.
And I think this last one is due to commit a3db503351e9 by Mattias.
That commit should probably add the lexical bindings line in the
mountpoint case, like this, which fixes the failure for me:
diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lisp/bytecomp-tests.el
index 4aa555f1e92..06918f5901c 100644
--- a/test/lisp/emacs-lisp/bytecomp-tests.el
+++ b/test/lisp/emacs-lisp/bytecomp-tests.el
@@ -1697,7 +1697,8 @@ bytecomp-tests--dest-mountpoint
(byte-compile-error-on-warn t))
(should-not (file-remote-p input-file))
(should-not (file-remote-p output-file))
- (write-region "" nil input-file nil nil nil 'excl)
+ (write-region ";;; -*-lexical-binding:t-*-\n"
+ nil input-file nil nil nil 'excl)
(write-region "" nil output-file nil nil nil 'excl)
(unwind-protect
(progn
(Seems that I happen to have this "bwrap" thingy installed, otherwise that
test gets skipped and may slip through.)
The failing test looks like this, if it matters:
------------------------- snip -------------------------
In end of data:
Warning: the function `an-undefined-function' is not known to be defined.
passed 15/99 bytecomp-test-featurep-warnings (0.000353 sec)
Test bytecomp-tests--dest-mountpoint backtrace:
signal(ert-test-failed (((status . 1) (output . ">>Error occurred pr
ert-fail(((status . 1) (output . ">>Error occurred processing /tmp/e
(if (eql status 0) nil (ert-fail (list (cons 'status status) (cons '
(let ((status (call-process bwrap nil t nil "--ro-bind" "/" "/" "--b
(progn (let ((status (call-process bwrap nil t nil "--ro-bind" "/" "
(unwind-protect (progn (let ((status (call-process bwrap nil t nil "
(save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
(let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
(progn (set-file-modes input-file 256) (set-file-modes output-file 1
(unwind-protect (progn (set-file-modes input-file 256) (set-file-mod
(let* ((input-file (expand-file-name "test.el" directory)) (output-f
(progn (let* ((input-file (expand-file-name "test.el" directory)) (o
(unwind-protect (progn (let* ((input-file (expand-file-name "test.el
(let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
(let ((bwrap (executable-find "bwrap")) (emacs (expand-file-name inv
(closure (t) nil (let ((bwrap (executable-find "bwrap")) (emacs (exp
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name bytecomp-tests--dest-mountpoint :docu
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/bytecomp-
command-line()
normal-top-level()
Test bytecomp-tests--dest-mountpoint condition:
(ert-test-failed
((status . 1)
(output .
">>Error occurred processing /tmp/emacs-test-BIdKcv-bytecomp/test.el: error ((\"file has no `lexical-binding' directive on its first line\"))\n")))
FAILED 16/99 bytecomp-tests--dest-mountpoint (0.056259 sec) at lisp/emacs-lisp/bytecomp-tests.el:1681
------------------------- snip -------------------------
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Native compilation unit tests failing since last weekend or so
2023-10-30 20:24 ` Jens Schmidt
@ 2023-11-01 8:21 ` Andrea Corallo
2023-11-03 20:25 ` bytecomp-tests still failing after Mattias' commit a3db503351e9 Jens Schmidt
1 sibling, 0 replies; 6+ messages in thread
From: Andrea Corallo @ 2023-11-01 8:21 UTC (permalink / raw)
To: Jens Schmidt; +Cc: emacs-devel, Mattias Engdegård
Jens Schmidt <jschmidt4gnu@vodafonemail.de> writes:
> On 2023-10-27 21:10, Jens Schmidt wrote:
>
>> I have been hoping these would go away ... on GNU/Linux, emacs-master,
>> with "-C --with-native-compilation --with-mailutils", after make
>> bootstrap:
>
> This got much better (thanks), I'm down to one failing unit test now.
Hi!
Yes sorry had some trouble and couldn't reply. The native comp bug was
highlighted by d7c91d74b659 and fixed by bdec2d2d464 fixed by Stefan M.
Thanks for reporting
Andrea
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bytecomp-tests still failing after Mattias' commit a3db503351e9
2023-10-30 20:24 ` Jens Schmidt
2023-11-01 8:21 ` Andrea Corallo
@ 2023-11-03 20:25 ` Jens Schmidt
2023-11-04 9:32 ` Mattias Engdegård
1 sibling, 1 reply; 6+ messages in thread
From: Jens Schmidt @ 2023-11-03 20:25 UTC (permalink / raw)
To: Mattias Engdegård; +Cc: emacs-devel
Changing subject (which I forgot last time) to catch Mattias' attention.
Mattias, could you please have a look? Nothing has changed as of today's
commit 6218278a67b5ce87eb5e8b2c76daeb7475983d35, this one test is still
failing. If you'd like to reproduce, you probably need to install package
bubblewrap or whatever provides "bwrap" on your distribution. Provided
you use GNU/Linux ...
Thanks.
On 2023-10-30 21:24, Jens Schmidt wrote:
> This got much better (thanks), I'm down to one failing unit test now.
> And I think this last one is due to commit a3db503351e9 by Mattias.
> That commit should probably add the lexical bindings line in the
> mountpoint case, like this, which fixes the failure for me:
>
> diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lisp/bytecomp-tests.el
> index 4aa555f1e92..06918f5901c 100644
> --- a/test/lisp/emacs-lisp/bytecomp-tests.el
> +++ b/test/lisp/emacs-lisp/bytecomp-tests.el
> @@ -1697,7 +1697,8 @@ bytecomp-tests--dest-mountpoint
> (byte-compile-error-on-warn t))
> (should-not (file-remote-p input-file))
> (should-not (file-remote-p output-file))
> - (write-region "" nil input-file nil nil nil 'excl)
> + (write-region ";;; -*-lexical-binding:t-*-\n"
> + nil input-file nil nil nil 'excl)
> (write-region "" nil output-file nil nil nil 'excl)
> (unwind-protect
> (progn
>
> (Seems that I happen to have this "bwrap" thingy installed, otherwise that
> test gets skipped and may slip through.)
>
> The failing test looks like this, if it matters:
>
> ------------------------- snip -------------------------
> In end of data:
> Warning: the function `an-undefined-function' is not known to be defined.
> passed 15/99 bytecomp-test-featurep-warnings (0.000353 sec)
> Test bytecomp-tests--dest-mountpoint backtrace:
> signal(ert-test-failed (((status . 1) (output . ">>Error occurred pr
> ert-fail(((status . 1) (output . ">>Error occurred processing /tmp/e
> (if (eql status 0) nil (ert-fail (list (cons 'status status) (cons '
> (let ((status (call-process bwrap nil t nil "--ro-bind" "/" "/" "--b
> (progn (let ((status (call-process bwrap nil t nil "--ro-bind" "/" "
> (unwind-protect (progn (let ((status (call-process bwrap nil t nil "
> (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
> (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
> (progn (set-file-modes input-file 256) (set-file-modes output-file 1
> (unwind-protect (progn (set-file-modes input-file 256) (set-file-mod
> (let* ((input-file (expand-file-name "test.el" directory)) (output-f
> (progn (let* ((input-file (expand-file-name "test.el" directory)) (o
> (unwind-protect (progn (let* ((input-file (expand-file-name "test.el
> (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
> (let ((bwrap (executable-find "bwrap")) (emacs (expand-file-name inv
> (closure (t) nil (let ((bwrap (executable-find "bwrap")) (emacs (exp
> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> ert-run-test(#s(ert-test :name bytecomp-tests--dest-mountpoint :docu
> ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
> ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
> ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
> ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
> command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/bytecomp-
> command-line()
> normal-top-level()
> Test bytecomp-tests--dest-mountpoint condition:
> (ert-test-failed
> ((status . 1)
> (output .
> ">>Error occurred processing /tmp/emacs-test-BIdKcv-bytecomp/test.el: error ((\"file has no `lexical-binding' directive on its first line\"))\n")))
> FAILED 16/99 bytecomp-tests--dest-mountpoint (0.056259 sec) at lisp/emacs-lisp/bytecomp-tests.el:1681
> ------------------------- snip -------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bytecomp-tests still failing after Mattias' commit a3db503351e9
2023-11-03 20:25 ` bytecomp-tests still failing after Mattias' commit a3db503351e9 Jens Schmidt
@ 2023-11-04 9:32 ` Mattias Engdegård
0 siblings, 0 replies; 6+ messages in thread
From: Mattias Engdegård @ 2023-11-04 9:32 UTC (permalink / raw)
To: Jens Schmidt; +Cc: emacs-devel
3 nov. 2023 kl. 21.25 skrev Jens Schmidt <jschmidt4gnu@vodafonemail.de>:
> Changing subject (which I forgot last time) to catch Mattias' attention.
Eh, wha? I missed the ending again? Did she survive this time?
> If you'd like to reproduce, you probably need to install package
> bubblewrap or whatever provides "bwrap" on your distribution. Provided
> you use GNU/Linux ...
So very sorry, my fruit machine always skips that test.
Anyway, your proposed
>> - (write-region "" nil input-file nil nil nil 'excl)
>> + (write-region ";;; -*-lexical-binding:t-*-\n"
>> + nil input-file nil nil nil 'excl)
fix is entirely reasonable and is now on master. Thank you!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-04 9:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-27 19:10 Native compilation unit tests failing since last weekend or so Jens Schmidt
2023-10-27 21:29 ` Alan Mackenzie
2023-10-30 20:24 ` Jens Schmidt
2023-11-01 8:21 ` Andrea Corallo
2023-11-03 20:25 ` bytecomp-tests still failing after Mattias' commit a3db503351e9 Jens Schmidt
2023-11-04 9:32 ` Mattias Engdegård
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).