unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: emacs-devel@gnu.org
Subject: Unhelpful text in C-h v search-default-mode
Date: Tue, 24 Oct 2023 09:45:59 +0000	[thread overview]
Message-ID: <ZTeSV-AZJkZ62XRq@ACM> (raw)

Hello, Emacs.

In a recent master branch Emacs, (not with -Q), from an info buffer, I
did C-h v search-default-mode.  The text printed in *Help* included this:

    Its value is
    #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_109>
    Original value was nil
    Local in buffer *info*<3>; global value is nil

..  This is quite frankly entirely unhelpful; it gives no way to find out
what the lambda is, in particular, no way to get to its source code.  It
isn't even possible to disassemble the function.

After a good deal of searching, I think I found the pertinent source
code, but am not sure, namely in isearch.el L4685, right near the end:

      (setq-local isearch-fold-quotes-mode--state
                  (buffer-local-set-state
                   search-default-mode
                   (lambda (string &optional _lax)
                     (thread-last
                       (regexp-quote string)
                       (replace-regexp-in-string "`" "[`‘]")
                       (replace-regexp-in-string "'" "['’]")
                       (replace-regexp-in-string "\"" "[\"""]")))))

..  Here, this customisable variable search-default-mode gets set to a
lambda function.  The problem could have been avoided if the extra effort
to come up with a symbol for this function had been expended, and the
function written separately as a defun with a name.

I am asking people to be careful not to use lambda forms like this,
instead always prefering defun and a name.

-- 
Alan Mackenzie (Nuremberg, Germany).



             reply	other threads:[~2023-10-24  9:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24  9:45 Alan Mackenzie [this message]
2023-10-25  6:43 ` Unhelpful text in C-h v search-default-mode Juri Linkov
2023-12-29  7:12 ` Juri Linkov
2023-12-29  7:21   ` Emanuel Berg
2023-12-29  7:50   ` Eli Zaretskii
2023-12-29  7:54     ` Eli Zaretskii
2023-12-30 17:40       ` Juri Linkov
2023-12-29 10:01   ` Alan Mackenzie
2023-12-29 10:58     ` Emanuel Berg
2023-12-30 17:43       ` Juri Linkov
2023-12-31  3:23         ` Emanuel Berg
2023-12-29 11:45     ` Eli Zaretskii
2023-12-29 20:19       ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTeSV-AZJkZ62XRq@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).