unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes
@ 2023-09-30  9:20 Jens Schmidt
  2023-09-30 14:36 ` Alan Mackenzie
  0 siblings, 1 reply; 2+ messages in thread
From: Jens Schmidt @ 2023-09-30  9:20 UTC (permalink / raw)
  To: emacs-devel, Alan Mackenzie

Seems commit 01229fe0096e936ea8f4fad0d64967671c4b1892 has
introduced a regression.  The following fixes it:


diff --git a/test/lisp/emacs-lisp/cl-print-tests.el b/test/lisp/emacs-lisp/cl-print-tests.el
index 3073a42e39d..3aac161b344 100644
--- a/test/lisp/emacs-lisp/cl-print-tests.el
+++ b/test/lisp/emacs-lisp/cl-print-tests.el
@@ -60,7 +60,8 @@ cl-print-tests-ellipsis-vector
 
 (ert-deftest cl-print-tests-ellipsis-string ()
   "Ellipsis expansion works in strings."
-  (let ((print-length 4)
+  (let ((cl-print-string-length 4)
+        (print-length 4)
         (print-level 3))
     (cl-print-tests-check-ellipsis-expansion
      "abcdefg" "\"abcd...\"" "efg")


But the fact that one has to bind `cl-print-string-length' *and*
`print-length' could indicate that the commit probably is not
"complete" yet.  In the sense that more occurrences of `print-length'
need to be modified in cl-print.el.



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes
  2023-09-30  9:20 Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes Jens Schmidt
@ 2023-09-30 14:36 ` Alan Mackenzie
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Mackenzie @ 2023-09-30 14:36 UTC (permalink / raw)
  To: Jens Schmidt; +Cc: emacs-devel

Hello, Jens.

On Sat, Sep 30, 2023 at 11:20:04 +0200, Jens Schmidt wrote:
> Seems commit 01229fe0096e936ea8f4fad0d64967671c4b1892 has
> introduced a regression.  The following fixes it:


> diff --git a/test/lisp/emacs-lisp/cl-print-tests.el b/test/lisp/emacs-lisp/cl-print-tests.el
> index 3073a42e39d..3aac161b344 100644
> --- a/test/lisp/emacs-lisp/cl-print-tests.el
> +++ b/test/lisp/emacs-lisp/cl-print-tests.el
> @@ -60,7 +60,8 @@ cl-print-tests-ellipsis-vector
 
>  (ert-deftest cl-print-tests-ellipsis-string ()
>    "Ellipsis expansion works in strings."
> -  (let ((print-length 4)
> +  (let ((cl-print-string-length 4)
> +        (print-length 4)
>          (print-level 3))
>      (cl-print-tests-check-ellipsis-expansion
>       "abcdefg" "\"abcd...\"" "efg")


> But the fact that one has to bind `cl-print-string-length' *and*
> `print-length' could indicate that the commit probably is not
> "complete" yet.  In the sense that more occurrences of `print-length'
> need to be modified in cl-print.el.

I simply forgot to commit the change to cl-print-tests.el, sorry.  I've
committed them now, so the tests should now run success-free again.

-- 
Alan Mackenzie (Nuremberg, Germany).



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-30 14:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-30  9:20 Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes Jens Schmidt
2023-09-30 14:36 ` Alan Mackenzie

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).