From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: make check produces 25 failures and hangs (bug #65176). Date: Sun, 13 Aug 2023 11:34:03 +0000 Message-ID: References: <9e9bf73a-f7e8-24e2-bd3f-5f4e86baa65e@vodafonemail.de> <83zg2ygmwu.fsf@gnu.org> <7f5635a2-c2bc-b90b-35b9-7c6a07822dae@vodafonemail.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24436"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , Eli Zaretskii , yandros@gmail.com, emacs-devel@gnu.org, Po Lu To: Jens Schmidt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 13 13:35:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qV9NP-0006Bv-4Z for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Aug 2023 13:35:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qV9MV-0007Ie-K4; Sun, 13 Aug 2023 07:34:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qV9MS-0007IT-MM for emacs-devel@gnu.org; Sun, 13 Aug 2023 07:34:20 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qV9MR-0003C2-54 for emacs-devel@gnu.org; Sun, 13 Aug 2023 07:34:20 -0400 Original-Received: (qmail 93783 invoked by uid 3782); 13 Aug 2023 13:34:04 +0200 Original-Received: from acm.muc.de (p4fe152a2.dip0.t-ipconnect.de [79.225.82.162]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 13 Aug 2023 13:34:03 +0200 Original-Received: (qmail 20362 invoked by uid 1000); 13 Aug 2023 11:34:03 -0000 Content-Disposition: inline In-Reply-To: <7f5635a2-c2bc-b90b-35b9-7c6a07822dae@vodafonemail.de> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308671 Archived-At: Hello, Jens. On Sun, Aug 13, 2023 at 12:59:26 +0200, Jens Schmidt wrote: > On 2023-08-12 21:09, Andrea Corallo wrote: > > To a very quick look seems to me `comp-subr-trampoline-install' is just > > not called as it should. AFAIR it should be called from Ffset, I'm > > really wondering what could have happened. > Probably because native-comp-enable-subr-trampolines equals nil in an > "emacs-master -Q"? > When I compare the following snippet from emacs-master/lisp/loadup.el: > (when (and (featurep 'native-compile) > (equal dump-mode "pdump")) > ;; Don't enable this before bootstrap is completed, as the > ;; compiler infrastructure may not be usable yet. > (setq comp-enable-subr-trampolines t)) > ^^^^ > to emacs-29: > (when (and (featurep 'native-compile) > (equal dump-mode "pdump")) > ;; Don't enable this before bootstrap is completed, as the > ;; compiler infrastructure may not be usable yet. > (setq native-comp-enable-subr-trampolines t)) > ^^^^^^^^^^^ Excellent debugging work! Thanks! > it seems that the android merge seems to be the culprit. But leaving > that to others to judge. There was a variable called comp-enable-subr-trampolines which got renamed to native-comp-..... on 2023-02-13 by Andrea in commit 5d0912f144. In the feature/android branch, which was possibly branched from main _before_ 2023-02-13, this flag was renamed back again to comp-enable-.... on 2023-02-18 by Po in commit 4ab9fa7507a. This likely followed a merge from main onto the android branch. It seems that native-comp-.... appeared to be a typo in the android branch, so it got "corrected" to comp-enable-.... to make the software work. This "correction" was then forgotten about, an easy mistake to make. > In any case, fixing that setq in emacs-master to refer to > `native-comp-enable-subr-trampolines' again fixes the issue, at least > as far as my "little repro case" is concerned ... running "make check" > ... yep, no more hangs at least on abbrevs-test.el. I would favour correcting that last use of comp-enable-subr-trampolines. -- Alan Mackenzie (Nuremberg, Germany).