From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: git commit message checker won't let me commit a new file. Date: Wed, 19 Jul 2023 11:10:32 +0000 Message-ID: References: <829deea6-a17c-47ba-104d-37a88d081a3e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18726"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Robert Pluim To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 19 13:11:44 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qM55r-0004bC-E7 for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Jul 2023 13:11:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qM54t-0001C0-EL; Wed, 19 Jul 2023 07:10:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qM54p-0001Br-N8 for emacs-devel@gnu.org; Wed, 19 Jul 2023 07:10:39 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qM54m-0003MW-ND for emacs-devel@gnu.org; Wed, 19 Jul 2023 07:10:39 -0400 Original-Received: (qmail 62965 invoked by uid 3782); 19 Jul 2023 13:10:33 +0200 Original-Received: from acm.muc.de (p4fe159a7.dip0.t-ipconnect.de [79.225.89.167]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 19 Jul 2023 13:10:32 +0200 Original-Received: (qmail 5492 invoked by uid 1000); 19 Jul 2023 11:10:32 -0000 Content-Disposition: inline In-Reply-To: <829deea6-a17c-47ba-104d-37a88d081a3e@gmail.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307969 Archived-At: Hello, Jim. On Tue, Jul 18, 2023 at 15:05:34 -0700, Jim Porter wrote: > On 7/18/2023 1:23 PM, Alan Mackenzie wrote: > > Hello, Emacs. > > I'm trying to commit a fix for bug #64642. This involves adding a new > > test file. > > The commit message checker says "File > > test/src/comp-resources/comp-test-funcs-dyn2.el: cannot be read: [No > > such file or directory] > > Commit aborted; please see the file CONTRIBUTE" > That's surprising. This works perfectly for me. Can you describe in more > detail how you're committing your change? Here's what I did: > $ git checkout -b testing > $ echo hi > test/src/comp-resources/comp-test-funcs-dyn2.el > $ git add test/src/comp-resources/comp-test-funcs-dyn2.el > $ git commit > In my editor, I add this for the commit message: > * test/src/comp-resources/comp-test-funcs-dyn2.el: New file. > The commit hooks run successfully for me and don't produce any errors. > Based on the output you see, I'm guessing the issue is in the > `commit-msg` hook, but I don't see anything in there that would do this. The fault is mine. I still had remnants of my own experiments with commit-msg in a version of commit-msg, and I had lots of symbolic links from my various repositories pointing at this. So I can sort it out, now. Sorry for wasting your time. -- Alan Mackenzie (Nuremberg, Germany).