From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: New branch feature/named-lambdas. Date: Tue, 18 Jul 2023 11:14:17 +0000 Message-ID: References: <87sf9m2u5a.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28610"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 18 13:16:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLigm-0007DW-Sd for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Jul 2023 13:16:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLifD-0003W0-Mr; Tue, 18 Jul 2023 07:14:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLif6-0003V2-Rs for emacs-devel@gnu.org; Tue, 18 Jul 2023 07:14:38 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLif3-0003Y6-8P for emacs-devel@gnu.org; Tue, 18 Jul 2023 07:14:35 -0400 Original-Received: (qmail 88581 invoked by uid 3782); 18 Jul 2023 13:14:18 +0200 Original-Received: from acm.muc.de (pd953a6f1.dip0.t-ipconnect.de [217.83.166.241]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 18 Jul 2023 13:14:17 +0200 Original-Received: (qmail 4870 invoked by uid 1000); 18 Jul 2023 11:14:17 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307949 Archived-At: Hello, Philip. On Mon, Jul 17, 2023 at 21:37:41 +0000, Alan Mackenzie wrote: > On Mon, Jul 17, 2023 at 19:52:01 +0000, Philip Kaludercic wrote: > > Alan Mackenzie writes: [ .... ] > > > This was achieved by adding an extra defining-symbol field to each of > > > the three forms of function (interpreted, byte-compiled, > > > native-compiled). It is indended that this version of Emacs will > > > continue to handle functions compiled without this enhancement. > > I think the idea is nice, but there are a lot of whitespace changes in > > your commit that make identifying the real changes a bit difficult. > Yes. I was instinctively correcting WS mis-alignment as I went along. > This was a mistake, sorry. > I've found a way to identify where these WS changes are, involving a git > diff, and a git diff -b, taking the diff -u between these two outputs, > then feeding that to grep '^[+-]@@'. This identifies 10 places where the > whitespace has changed. I hope that's all of them, but I'll check. > I'll go through these tomorrow morning and commit them to > feature/named-lambdas. This will have the advantage of making my patch > file several hundred lines shorter. ;-) I've reverted a few whitespace changes (together with an unintentional deletion of a condition-case in comp.el). Most of the the WS changes were actually due to semantic changes, e.g. by enclosing a block of forms in an extra (let ....). It can help to use the -b flag in git diff (or indeed in diff itself), e.g. git diff -b master..feature/named-lambdas .. > -- > Alan Mackenzie (Nuremberg, Germany).