From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: New function safe-copy-tree. Date: Tue, 7 Mar 2023 15:52:45 +0000 Message-ID: References: <8ACCC822-32D0-40D5-A68E-43E3A7EE7926@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 07 16:53:41 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZZdD-000A2k-BR for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Mar 2023 16:53:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZZcT-0003aU-DP; Tue, 07 Mar 2023 10:52:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZZcS-0003aM-9j for emacs-devel@gnu.org; Tue, 07 Mar 2023 10:52:52 -0500 Original-Received: from mx3.muc.de ([193.149.48.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZZcQ-0008FG-HH for emacs-devel@gnu.org; Tue, 07 Mar 2023 10:52:52 -0500 Original-Received: (qmail 60858 invoked by uid 3782); 7 Mar 2023 16:52:47 +0100 Original-Received: from acm.muc.de (pd953aca1.dip0.t-ipconnect.de [217.83.172.161]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 07 Mar 2023 16:52:47 +0100 Original-Received: (qmail 26890 invoked by uid 1000); 7 Mar 2023 15:52:45 -0000 Content-Disposition: inline In-Reply-To: <8ACCC822-32D0-40D5-A68E-43E3A7EE7926@gmail.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304091 Archived-At: Hello, Mattias. On Tue, Mar 07, 2023 at 14:37:09 +0100, Mattias Engdegård wrote: > 6 mars 2023 kl. 22.14 skrev Alan Mackenzie : > > In order to fix bug #61962, I'm intending to introduce a new function > > safe-copy-tree in subr.el. It is like copy-tree, except it works with > > circular lists as well as normal ones. > Seems more than a little heavy-handed to me, and the implementation > isn't without problems. Yes. Help making it more elegant would be appreciated. > I'll take a closer look at your patch a bit later on but right now I'm > short of time. Please attach the patch to bug#61962 meanwhile and let's > continue the discussion there. OK, but safe-copy-tree isn't really part of bug #61962, it's more a general function which the bug fix happened to need, but wasn't there. -- Alan Mackenzie (Nuremberg, Germany).