From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: src/Makefile unhelpful Date: Sat, 17 Sep 2022 11:20:40 +0000 Message-ID: References: <875yhui674.fsf@gnus.org> <8735cy5dg9.fsf@yahoo.com> <83bkrj45lr.fsf@gnu.org> <87zgf12036.fsf@gnus.org> <2b58b8f5425fc083d4ad@heytings.org> <877d251540.fsf@gnus.org> <0b5f34d9bc43b17dd0df@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11763"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Eli Zaretskii , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 17 13:22:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZVts-0002x0-55 for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Sep 2022 13:22:20 +0200 Original-Received: from localhost ([::1]:56866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZVtr-0003xK-7V for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Sep 2022 07:22:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZVsN-00037d-If for emacs-devel@gnu.org; Sat, 17 Sep 2022 07:20:47 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:36567) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZVsL-00060d-Fu for emacs-devel@gnu.org; Sat, 17 Sep 2022 07:20:47 -0400 Original-Received: (qmail 72538 invoked by uid 3782); 17 Sep 2022 13:20:41 +0200 Original-Received: from acm.muc.de (p2e5d5056.dip0.t-ipconnect.de [46.93.80.86]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 17 Sep 2022 13:20:41 +0200 Original-Received: (qmail 5526 invoked by uid 1000); 17 Sep 2022 11:20:40 -0000 Content-Disposition: inline In-Reply-To: <0b5f34d9bc43b17dd0df@heytings.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295522 Archived-At: Hello, Gregory. On Sat, Sep 17, 2022 at 10:46:24 +0000, Gregory Heytings wrote: > Complete patch attached, comments welcome. Just a small point in English usage: > I added a (minimal) sanity check, too. I remember at least one case when > make "failed to fail", it returned 0 even though the build did in fact not > succeed. > + > +# ADVICE-ON-FAILURE-BEGIN > +# You might consider to: > +# - run "make bootstrap", which might fix the problem > +# - run "git clean -fdx" and run "make" again, which might fix > +# the problem if it was not fixed by "make bootstrap" > +# !BEWARE! "git clean -fdx" restores the local repository in its > +# !BEWARE! pristine state, it deletes all local changes and all > +# !BEWARE! untracked files > +# - run "make V=1", which displays the full commandes invoked by > +# make, to further investigate the problem > +# ADVICE-ON-FAILURE-END > + The verb "consider" takes a gerund (or noun), not an infinitive. So the above really ought to be: You might consider: - running .... , with the other "run"s being changed to "running", too. Alternatively, one could use instead the verb "try", which can take an infinitive (or a gerund or noun ;-). -- Alan Mackenzie (Nuremberg, Germany).