From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: font-lock-reference-face no longer defined? Date: Fri, 16 Sep 2022 19:01:31 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5976"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel =?iso-8859-1?Q?Mart=EDn?= , "T.V Raman" , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 16 21:03:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZGcO-0001QM-Mv for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Sep 2022 21:03:16 +0200 Original-Received: from localhost ([::1]:38818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZGcN-0002bZ-N7 for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Sep 2022 15:03:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZGao-0001mx-Nk for emacs-devel@gnu.org; Fri, 16 Sep 2022 15:01:39 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:10599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZGam-0006sj-Fp for emacs-devel@gnu.org; Fri, 16 Sep 2022 15:01:38 -0400 Original-Received: (qmail 21870 invoked by uid 3782); 16 Sep 2022 21:01:32 +0200 Original-Received: from acm.muc.de (p4fe15d67.dip0.t-ipconnect.de [79.225.93.103]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 16 Sep 2022 21:01:32 +0200 Original-Received: (qmail 20189 invoked by uid 1000); 16 Sep 2022 19:01:31 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295501 Archived-At: Hello, Stefan. On Fri, Sep 16, 2022 at 14:26:35 -0400, Stefan Monnier wrote: > > It was an obsolete alias since Emacs 20.3 and was removed by this > > commit: > [...] > > Code should use font-lock-constant-face instead. I'm also confused > > because I still see references to the old variable name in the Emacs > > codebase. > There was one reference left in `lisp/cedet/semantic/grammar.el` which > I just fixed, the rest is all in CC-mode, which I'll leave to Alan. I've been sorting this out the last few days, and it should be OK now. It's perhaps more complicated than it need be. The way CC Mode works with this face is that when the test suite is running, the test suite creates font-lock-reference-face (along with a few others) if it doesn't already exist. (It doesn't in Emacs 29.) c-reference-face-name is then set to (the artificial) font-lock-reference-face. On the other hand, when Emacs 29 is running normally, f-l-ref-face doesn't exist, so c-reference-face-name is set to font-lock-constant-face, as is recommended. > Stefan -- Alan Mackenzie (Nuremberg, Germany).