unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Daniel Martín" <mardani29@yahoo.es>,
	"T.V Raman" <raman@google.com>,
	emacs-devel@gnu.org
Subject: Re: font-lock-reference-face no longer defined?
Date: Fri, 16 Sep 2022 19:01:31 +0000	[thread overview]
Message-ID: <YyTIC169trJfODBI@ACM> (raw)
In-Reply-To: <jwvk063tc4t.fsf-monnier+emacs@gnu.org>

Hello, Stefan.

On Fri, Sep 16, 2022 at 14:26:35 -0400, Stefan Monnier wrote:
> > It was an obsolete alias since Emacs 20.3 and was removed by this
> > commit:
> [...]
> > Code should use font-lock-constant-face instead.  I'm also confused
> > because I still see references to the old variable name in the Emacs
> > codebase.

> There was one reference left in `lisp/cedet/semantic/grammar.el` which
> I just fixed, the rest is all in CC-mode, which I'll leave to Alan.

I've been sorting this out the last few days, and it should be OK now.
It's perhaps more complicated than it need be.

The way CC Mode works with this face is that when the test suite is
running, the test suite creates font-lock-reference-face (along with a
few others) if it doesn't already exist.  (It doesn't in Emacs 29.)
c-reference-face-name is then set to (the artificial)
font-lock-reference-face.

On the other hand, when Emacs 29 is running normally, f-l-ref-face
doesn't exist, so c-reference-face-name is set to
font-lock-constant-face, as is recommended.

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).



      parent reply	other threads:[~2022-09-16 19:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 17:28 font-lock-reference-face no longer defined? T.V Raman
2022-09-16 17:50 ` Daniel Martín
2022-09-16 18:00   ` T.V Raman
2022-09-16 18:26   ` Stefan Monnier
2022-09-16 18:32     ` T.V Raman
2022-09-16 18:51       ` Stefan Monnier
2022-09-16 19:29         ` Stefan Kangas
2022-09-16 20:46         ` T.V Raman
2022-09-16 19:01     ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyTIC169trJfODBI@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=mardani29@yahoo.es \
    --cc=monnier@iro.umontreal.ca \
    --cc=raman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).