unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jean Louis <bugs@gnu.support>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Philip Kaludercic <philipk@posteo.net>,
	Andreas Schwab <schwab@linux-m68k.org>,
	emacs-devel@gnu.org
Subject: Re: Deprecation of define-key?
Date: Sun, 31 Jul 2022 09:48:27 +0300	[thread overview]
Message-ID: <YuYlu0kCuFLA915K@protected.localdomain> (raw)
In-Reply-To: <87sfmizump.fsf@gnus.org>

* Lars Ingebrigtsen <larsi@gnus.org> [2022-07-30 14:51]:
> Philip Kaludercic <philipk@posteo.net> writes:
> 
> > That is obvious, the question is should package developers avoid using
> > `define-key' if possible or not?
> 
> As the doc string says -- `keymap-set' is the recommended function to
> use.  However, `define-key' is not (and won't be) obsoleted, so it's up
> to them to follow the recommendation (or not).

After replacing `define-key' with `keymap-set' I got following:

Debugger entered--Lisp error: (error "[8388710] is not a valid key definition; see ‘key-valid-p’")
  signal(error ("[8388710] is not a valid key definition; see ‘key-..."))
  error("%S is not a valid key definition; see `key-valid-p..." [8388710])
  keymap--check([8388710])

for this definition:

(keymap-set dired-mode-map (kbd "s-f") 'cf-file-for-person)

So how I am supposed to make it work? I need to use the super key and
F to file files under person's directory.

-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/



  reply	other threads:[~2022-07-31  6:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29 15:33 Deprecation of define-key? Philip Kaludercic
2022-07-29 16:16 ` Andreas Schwab
2022-07-30 11:46   ` Philip Kaludercic
2022-07-30 11:51     ` Lars Ingebrigtsen
2022-07-31  6:48       ` Jean Louis [this message]
2022-07-31  7:14         ` Visuwesh
2022-08-02  9:44       ` Augusto Stoffel
2022-08-02  9:54         ` Philip Kaludercic
2022-08-02 10:01           ` Lars Ingebrigtsen
2022-08-02 10:06             ` Philip Kaludercic
2022-08-02 10:11               ` Lars Ingebrigtsen
2022-08-02 10:00         ` Lars Ingebrigtsen
2022-08-02 10:11           ` Philip Kaludercic
2022-08-02 10:46             ` Lars Ingebrigtsen
2022-08-02 10:14           ` Augusto Stoffel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuYlu0kCuFLA915K@protected.localdomain \
    --to=bugs@gnu.support \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=philipk@posteo.net \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).