From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Don't move to eol in end-of-defun? Date: Sat, 6 Aug 2022 09:33:39 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21164"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Filipp Gunbin , emacs-devel@gnu.org To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 06 11:37:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oKGFX-0005JS-Us for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Aug 2022 11:37:39 +0200 Original-Received: from localhost ([::1]:56564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKGFW-0007yI-Oi for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Aug 2022 05:37:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKGBk-0006VB-PD for emacs-devel@gnu.org; Sat, 06 Aug 2022 05:33:44 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:39993 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1oKGBi-0000CZ-J0 for emacs-devel@gnu.org; Sat, 06 Aug 2022 05:33:44 -0400 Original-Received: (qmail 12480 invoked by uid 3782); 6 Aug 2022 09:33:40 -0000 Original-Received: from acm.muc.de (p2e5d57a4.dip0.t-ipconnect.de [46.93.87.164]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 06 Aug 2022 11:33:39 +0200 Original-Received: (qmail 5059 invoked by uid 1000); 6 Aug 2022 09:33:39 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293139 Archived-At: Hello, Richard. On Fri, Aug 05, 2022 at 23:41:39 -0400, Richard Stallman wrote: > [[[ To any NSA and FBI agents reading my email: please consider ]]] > [[[ whether defending the US Constitution against all enemies, ]]] > [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > We have nested defuns here. > A "defun" in Emacs is not the same thing as a function definition > (or class definition). > class C { > void foo() { > } > } > has two nested definitions, but only the outermost one counts as a > defun in Emacs parlance. > A defun is a construct which is top-level, or appears locally to be. > In Lisp that usually means an open-paren in column 0. In some other > languages, there are other ways to find defuns. > > I just want to make movement to eol conditional, with default value > > meaning "like before", to not break anything. To clarify, Filipp's problem is the current implementation of end-of-defun in lisp/emacs-lisp/lisp.el. There are two alternatives in this function. Either it moves up the parenthesis structure, like for Emacs Lisp Mode, or it calls the mode specific function end-of-defun-function instead. The problem is that e-o-d moves point somewhere else _before_ it calls end-of-defun-function, and that somewhere else can easily be in a different (nested) defun. I think Filipp is asking for the coding of end-of-defun to be revisited. > Doing it that way might be ok. At any rate, no disaster. But it > leaves the question, should we really try to support nested defuns? > It is a can of worms. CC Mode has supported these nested defuns for many years, now. For example, in C++, it is common for a source file to begin with namespace foo { , and the rest of the functions/methods/classes in the file to be enclosed within that namespace. In these circumstances, for C-M-a to go to the outermost "defun" wouldn't be useful. CC Mode has C-M-a moving to the previous start of defun at the current level of namespace/class/struct nesting, or the next level outwards when we bump up against the defining namespace/class/struct start. C-M-e works likewise. This works well, and there have been remarkably few bug reports about it (I can't actually remember any). > -- > Dr Richard Stallman (https://stallman.org) > Chief GNUisance of the GNU Project (https://gnu.org) > Founder, Free Software Foundation (https://fsf.org) > Internet Hall-of-Famer (https://internethalloffame.org) -- Alan Mackenzie (Nuremberg, Germany).