From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: New optimisations for long raw strings in C++ Mode. Date: Sun, 7 Aug 2022 14:40:47 +0000 Message-ID: References: <87r11s2p7f.fsf@gnus.org> <87fsi818ju.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10028"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 07 16:41:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oKhTC-0002Sk-9b for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Aug 2022 16:41:34 +0200 Original-Received: from localhost ([::1]:51948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKhTA-00015q-UT for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Aug 2022 10:41:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKhSX-0000P2-BV for emacs-devel@gnu.org; Sun, 07 Aug 2022 10:40:53 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:29772 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1oKhSV-0002uc-91 for emacs-devel@gnu.org; Sun, 07 Aug 2022 10:40:53 -0400 Original-Received: (qmail 85325 invoked by uid 3782); 7 Aug 2022 14:40:48 -0000 Original-Received: from acm.muc.de (p2e5d5157.dip0.t-ipconnect.de [46.93.81.87]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 07 Aug 2022 16:40:48 +0200 Original-Received: (qmail 5245 invoked by uid 1000); 7 Aug 2022 14:40:47 -0000 Content-Disposition: inline In-Reply-To: <87fsi818ju.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293208 Archived-At: Hello, Lars. On Sun, Aug 07, 2022 at 15:34:45 +0200, Lars Ingebrigtsen wrote: > Alan Mackenzie writes: > > Hmm. Something is different on my setup from yours. After my > > optimisations, I do: > Is this on the current trunk? Yes, after the committing of commit a332034160bf8e1f38039cd2d37898de6f94508f Author: Alan Mackenzie Date: Sun Aug 7 12:26:16 2022 +0000 CC Mode: Fix looping in patch from yesterday > > (i) Emacs -Q > > (ii) M-: (setq long-line-threshold nil) > > (ii) C-x C-f ~/long-line.cc RET; This is a file containing a 1MB raw > > string. > > (iii) This loads and displays in somewhere between 1 and 2 seconds. > > (iv) C-x 5 b long-line2.cc RET M-x c++-mode RET > > (v) Type in char long_line [] = R"foo( > > (vi) Type in RET, twice > > (vii) Type in )foo"; > Yup. > > (ix) C-x 5 o > > (x) Get the long line into the kill ring, with movement commands and > > M-w. > > (xi) C-x 5 o. > > (xii) Put point on the blank line 2. > > (xiii) C-y. > > (xiv) This takes less than a second to display. > It's still hanging for me after 20s. > > What does your 1MB string look like? Does it contain lots of "s? CC > > Mode needs to search through the yanked line for the first occurrence of > > )foo", which is why it is not instantaneous. It also has to put a > > syntax-table text property on each " which isn't the terminating )foo", > > which is another reason it's not instantaneous. > The string I'm yanking is just 1MB worth of x and y characters (and no > spaces or anything). Mine looked like "012345678 012345678 012345678 .... 012345678 ". I tried replacing each space by a 9, but the string still yanks with the expected minimal sluggishness. Actually, I just tried it again after M-: (setq long-line-threshold 10000). It hangs. Did you omit step (ii) above, by any chance? -- Alan Mackenzie (Nuremberg, Germany).