From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Can't build previous versions of Emacs? Date: Thu, 14 Jul 2022 19:02:04 +0000 Message-ID: References: <877d4gcr7g.fsf@ericabrahamsen.net> <87ilo0s70s.fsf@yahoo.com> <8735f3d655.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5631"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eric Abrahamsen , emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 14 21:04:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oC485-0001Dq-Gy for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Jul 2022 21:04:05 +0200 Original-Received: from localhost ([::1]:35494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oC484-0007Ch-EP for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Jul 2022 15:04:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC46E-0005lD-FC for emacs-devel@gnu.org; Thu, 14 Jul 2022 15:02:10 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:15415 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1oC46C-0008OV-62 for emacs-devel@gnu.org; Thu, 14 Jul 2022 15:02:10 -0400 Original-Received: (qmail 27525 invoked by uid 3782); 14 Jul 2022 19:02:05 -0000 Original-Received: from acm.muc.de (p4fe15c93.dip0.t-ipconnect.de [79.225.92.147]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 14 Jul 2022 21:02:04 +0200 Original-Received: (qmail 23515 invoked by uid 1000); 14 Jul 2022 19:02:04 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292170 Archived-At: Hello, Ulrich. On Thu, Jul 14, 2022 at 19:07:53 +0200, Ulrich Mueller wrote: > >>>>> On Thu, 14 Jul 2022, Eric Abrahamsen wrote: > > Po Lu writes: > >> Eric Abrahamsen writes: > >>> Hi all, > >>> I have the Emacs 25, 26 and 27 branches checked out in git worktrees, > >>> and I was going to build them to test some backwards compatibility. On a > >>> clean checkout, "make" failed for all three of them with this error: > >>> sysdep.c:1795:22: error: variably modified ‘sigsegv_stack’ at file scope > >>> 1795 | static unsigned char sigsegv_stack[SIGSTKSZ]; > >>> | ^~~~~~~~~~~~~ > >>> make[2]: *** [Makefile:377: sysdep.o] Error 1 > >>> make[2]: Leaving directory '/home/eric/dev/emacs-26/src' > >>> make[1]: *** [Makefile:421: src] Error 2 > >>> make[1]: Leaving directory '/home/eric/dev/emacs-26' > >>> make: *** [Makefile:1107: bootstrap] Error 2 > >>> This is on Arch Linux, I can send the config.status file for any of the > >>> branches if that would help. > >> That's expected. glibc recently changed in that SIGSTKSZ is now a call > >> to a function. Emacs wasn't modified to be compatible with that until > >> 28.1. > > Thanks! That's good to know. > You can find patches for the SIGSTKSZ issue here: > https://gitweb.gentoo.org/proj/emacs-patches.git/tree/emacs > For example, for Emacs 27.2: > https://gitweb.gentoo.org/proj/emacs-patches.git/tree/emacs/27.2/02_all_glibc-2.34.patch Brilliant! For somebody who's got lots of branches to amend, the following (or something like it) might come in handy. Test it first before using it in earnest! find . -name sysdep.c | xargs sed -i~ 's/sigsegv_stack\[SIGSTKSZ\]/sigsegv_stack[32768]/' I just fixed 26 copies of Emacs, both in /usr/local/src and my repository structure. -- Alan Mackenzie (Nuremberg, Germany).