From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Two CC Mode bug fixes into the release branch? Date: Sat, 2 Jul 2022 15:18:04 +0000 Message-ID: References: <83o7y7bmqg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14993"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 02 17:19:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7etm-0003fA-AX for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Jul 2022 17:19:06 +0200 Original-Received: from localhost ([::1]:37312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7etl-000231-E7 for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Jul 2022 11:19:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7ess-0001Io-Nl for emacs-devel@gnu.org; Sat, 02 Jul 2022 11:18:10 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:46025 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1o7esq-0001Nq-LQ for emacs-devel@gnu.org; Sat, 02 Jul 2022 11:18:10 -0400 Original-Received: (qmail 2812 invoked by uid 3782); 2 Jul 2022 15:18:06 -0000 Original-Received: from acm.muc.de (p4fe15928.dip0.t-ipconnect.de [79.225.89.40]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 02 Jul 2022 17:18:06 +0200 Original-Received: (qmail 15086 invoked by uid 1000); 2 Jul 2022 15:18:04 -0000 Content-Disposition: inline In-Reply-To: <83o7y7bmqg.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291798 Archived-At: Hello, Eli. On Sat, Jul 02, 2022 at 17:41:43 +0300, Eli Zaretskii wrote: > > Date: Sat, 2 Jul 2022 14:06:12 +0000 > > From: Alan Mackenzie > > The first is bug #53605 (from Richard Copley in January) which has just > > been reported again by somebody else on bug-cc-mode@gnu.org. The > > problem is that the C++ line > > operator""_hexstring() > > gets parsed as > > operatoR""_hexstring() > > and handled wrongly as a raw string. The solution to this bug is to > > bind case-fold-search to nil in one place. > Please tell which commit you want to cherry-pick. I'd like to be sure > we are talking about the same thing. OK, this commit: commit cf9c40159a6bef5a23f7b23a45c03f0c6be57574 Author: Alan Mackenzie Date: Mon Jan 31 17:44:59 2022 +0000 * lisp/progmodes/cc-mode.el (c-common-init): Bind case-fold-search to nil This fixes bug #53605. It is best viewed with a -b flag, as in $ git show -b cf9c40159a. > > The second is bug #56256 where an unusual set of circumstances (a C++ > > lambda form being opened in a #define) causes Emacs to lock up hard. > > The solution is simple (as these things often are), replacing a call to > > c-backward-token-2 with a save-excursion and a goto-char. > > This may not happen often, but the consequence would appear serious > > enough to warrant fixing the bug in the emacs-28 branch. > Is the change you want to install the same one shown in the discussion > of that bug? If not, please show the change. Yes, it's the change I send off to the OP on 2022-06-29, asking him/her to test it. -- Alan Mackenzie (Nuremberg, Germany).