unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Two CC Mode bug fixes into the release branch?
Date: Sat, 2 Jul 2022 15:18:04 +0000	[thread overview]
Message-ID: <YsBhrNhh8AQ9AVMI@ACM> (raw)
In-Reply-To: <83o7y7bmqg.fsf@gnu.org>

Hello, Eli.

On Sat, Jul 02, 2022 at 17:41:43 +0300, Eli Zaretskii wrote:
> > Date: Sat, 2 Jul 2022 14:06:12 +0000
> > From: Alan Mackenzie <acm@muc.de>

> > The first is bug #53605 (from Richard Copley in January) which has just
> > been reported again by somebody else on bug-cc-mode@gnu.org.  The
> > problem is that the C++ line

> >     operator""_hexstring()

> > gets parsed as

> >     operatoR""_hexstring()

> > and handled wrongly as a raw string.  The solution to this bug is to
> > bind case-fold-search to nil in one place.

> Please tell which commit you want to cherry-pick.  I'd like to be sure
> we are talking about the same thing.

OK, this commit:

commit cf9c40159a6bef5a23f7b23a45c03f0c6be57574
Author: Alan Mackenzie <acm@muc.de>
Date:   Mon Jan 31 17:44:59 2022 +0000

    * lisp/progmodes/cc-mode.el (c-common-init): Bind case-fold-search to nil

    This fixes bug #53605.

It is best viewed with a -b flag, as in $ git show -b cf9c40159a.


> > The second is bug #56256 where an unusual set of circumstances (a C++
> > lambda form being opened in a #define) causes Emacs to lock up hard.

> > The solution is simple (as these things often are), replacing a call to
> > c-backward-token-2 with a save-excursion and a goto-char.

> > This may not happen often, but the consequence would appear serious
> > enough to warrant fixing the bug in the emacs-28 branch.

> Is the change you want to install the same one shown in the discussion
> of that bug?  If not, please show the change.

Yes, it's the change I send off to the OP on 2022-06-29, asking him/her
to test it.

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2022-07-02 15:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-02 14:06 Two CC Mode bug fixes into the release branch? Alan Mackenzie
2022-07-02 14:41 ` Eli Zaretskii
2022-07-02 15:18   ` Alan Mackenzie [this message]
2022-07-02 15:26     ` Eli Zaretskii
2022-07-02 15:33       ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsBhrNhh8AQ9AVMI@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).