From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Two CC Mode bug fixes into the release branch? Date: Sat, 2 Jul 2022 14:06:12 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21315"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 02 16:13:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7ds8-0005SD-75 for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Jul 2022 16:13:20 +0200 Original-Received: from localhost ([::1]:33182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7ds6-0007OT-Ux for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Jul 2022 10:13:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7dlK-0005d9-6P for emacs-devel@gnu.org; Sat, 02 Jul 2022 10:06:18 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:44132 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1o7dlI-0002nM-5k for emacs-devel@gnu.org; Sat, 02 Jul 2022 10:06:17 -0400 Original-Received: (qmail 55720 invoked by uid 3782); 2 Jul 2022 14:06:13 -0000 Original-Received: from acm.muc.de (p4fe15928.dip0.t-ipconnect.de [79.225.89.40]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 02 Jul 2022 16:06:12 +0200 Original-Received: (qmail 14422 invoked by uid 1000); 2 Jul 2022 14:06:12 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291796 Archived-At: Hello, Emacs. I think it would be right to put two recent CC Mode bug fixes into the release branch. The first is bug #53605 (from Richard Copley in January) which has just been reported again by somebody else on bug-cc-mode@gnu.org. The problem is that the C++ line operator""_hexstring() gets parsed as operatoR""_hexstring() and handled wrongly as a raw string. The solution to this bug is to bind case-fold-search to nil in one place. This was fixed in the master branch in February. It would seem that this is likely to happen quite a lot, so maybe the fix should be copied into the release branch now. The second is bug #56256 where an unusual set of circumstances (a C++ lambda form being opened in a #define) causes Emacs to lock up hard. The solution is simple (as these things often are), replacing a call to c-backward-token-2 with a save-excursion and a goto-char. This may not happen often, but the consequence would appear serious enough to warrant fixing the bug in the emacs-28 branch. Should I put either of these fixes into the release branch? -- Alan Mackenzie (Nuremberg, Germany).