unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point
Date: Sun, 22 May 2022 19:26:22 +0000	[thread overview]
Message-ID: <YoqOXokj7bVBJQof@ACM> (raw)
In-Reply-To: <87sfp1sa8h.fsf@gnus.org>

Hello, Lars.

On Sun, May 22, 2022 at 20:17:18 +0200, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> >     CC Mode: Restore string fence properties at each relevant external entry point

> I'm not sure whether it's this change or not, ....

I'm afraid it is, definitely.

> ...., but this test broke tonight:

> 2 unexpected results:
>    FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings
>    FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c-mode-in-strings

Yes.  The relevant functionality for these electric-pair test must take
place in a region of code WITHOUT these string fence properties applied.
This should be fairly simple to fix, but I probably won't be doing it
this evening.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2022-05-22 19:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165323885598.20616.17995667057596262189@vcs2.savannah.gnu.org>
     [not found] ` <20220522170056.5E168C009A8@vcs2.savannah.gnu.org>
2022-05-22 18:17   ` master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point Lars Ingebrigtsen
2022-05-22 19:26     ` Alan Mackenzie [this message]
2022-05-24 16:41     ` Alan Mackenzie
2022-05-24 16:50       ` Lars Ingebrigtsen
2022-05-24 16:51         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoqOXokj7bVBJQof@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).