From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Proposed removal of struct frame->select_mini_window_flag. Date: Wed, 18 May 2022 15:56:28 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4776"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 18 17:59:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrM55-00014h-O4 for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 17:59:23 +0200 Original-Received: from localhost ([::1]:60098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrM54-0001Lw-Nh for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 11:59:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrM2L-0007Ib-1v for emacs-devel@gnu.org; Wed, 18 May 2022 11:56:34 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:46888 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1nrM2I-00013z-UB for emacs-devel@gnu.org; Wed, 18 May 2022 11:56:32 -0400 Original-Received: (qmail 86990 invoked by uid 3782); 18 May 2022 15:56:28 -0000 Original-Received: from acm.muc.de (p4fe15a4c.dip0.t-ipconnect.de [79.225.90.76]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 18 May 2022 17:56:28 +0200 Original-Received: (qmail 19659 invoked by uid 1000); 18 May 2022 15:56:28 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289924 Archived-At: I came across struct frame->select_mini_window_flag while looking at bug #55414. More accurately, my attention was diverted for over an hour, trying to work out how this boolean could be maintained in a consistent state, given that it gets splatted to false every time Fselect_window gets called. Then it dawned on me that the variable has no function - if the mini-window is the selected window, this is fully represented by struct frame->selected_window's value. So, I propose to remove this variable and all its "uses". Does anybody object? -- Alan Mackenzie (Nuremberg, Germany).