From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.devel Subject: Re: master 8ee21db4af: Add new function `read-string-from-buffer'. Date: Wed, 18 May 2022 08:17:44 +0300 Message-ID: References: <165080616575.16300.17375829044466066664@vcs2.savannah.gnu.org> <20220424131606.1E4FEC009A8@vcs2.savannah.gnu.org> <8735i2wpc0.fsf@athena.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37146"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.2.0 (2022-02-12) Cc: Sean Whitton , Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 18 20:51:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrOlP-0009Of-JC for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 20:51:15 +0200 Original-Received: from localhost ([::1]:35196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrOlN-0003Qp-P1 for ged-emacs-devel@m.gmane-mx.org; Wed, 18 May 2022 14:51:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrOk4-0002TR-Tz for emacs-devel@gnu.org; Wed, 18 May 2022 14:49:52 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:52015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrOk2-0002r0-La for emacs-devel@gnu.org; Wed, 18 May 2022 14:49:52 -0400 Original-Received: from localhost ([::ffff:197.239.7.237]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 000000000006FFBF.0000000062853FCC.00002C49; Wed, 18 May 2022 11:49:48 -0700 Mail-Followup-To: Stefan Monnier , Sean Whitton , Lars Ingebrigtsen , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, RCVD_IN_SBL=0.141, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289932 Archived-At: * Stefan Monnier [2022-04-29 16:54]: > Jean Louis [2022-04-29 16:18:48] wrote: > > * Stefan Monnier [2022-04-29 15:21]: > >> Jean Louis [2022-04-29 12:44:41] wrote: > >> > (defun read-from-buffer (&optional value buffer-name mode title keymap place > >> > highlight-list minor-modes) > >> > >> I'd collapse those "mode title keymap place highlight-list minor-modes" > >> into a singe `setup-function` argument. > > > > Is there example of that to help me understand it? > > > > Do you mean `setup-function` should be a list or hash, or similar data > > type which is then parsed by function? > > No, I mean a formal argument called `setup-function` which > `read-from-buffer` would call (probably with 0 arguments) in the buffer. > > So instead of: > > (read-from-buffer "My prompt: " "*The Buffer*" > #'foo-mode nil foo-map nil nil (list #'bar-minor-mode)) > > you'd write: > > (read-from-buffer "My prompt: " "*The Buffer*" > (lambda () > (foo-mode) > (use-local-map foo-map) > (bar-minor-mode 1))) > I got that, thank you. That is generally good idea for some functions that require more arguments. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/