From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.devel Subject: Re: master 8ee21db4af: Add new function `read-string-from-buffer'. Date: Fri, 29 Apr 2022 12:44:41 +0300 Message-ID: References: <165080616575.16300.17375829044466066664@vcs2.savannah.gnu.org> <20220424131606.1E4FEC009A8@vcs2.savannah.gnu.org> <8735i2wpc0.fsf@athena.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4540"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.2.0 (2022-02-12) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 12:02:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkNSI-00011h-3E for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 12:02:30 +0200 Original-Received: from localhost ([::1]:45358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkNSG-0004ou-Ql for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 06:02:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkNQN-0003bu-PY for emacs-devel@gnu.org; Fri, 29 Apr 2022 06:00:37 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:43597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkNQI-0001f6-78 for emacs-devel@gnu.org; Fri, 29 Apr 2022 06:00:31 -0400 Original-Received: from localhost ([::ffff:197.239.4.39]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 0000000000067F95.00000000626BB718.00006DFA; Fri, 29 Apr 2022 02:59:51 -0700 Mail-Followup-To: Sean Whitton , Lars Ingebrigtsen , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <8735i2wpc0.fsf@athena.silentflame.com> Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SBL=0.141, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288971 Archived-At: I am using similar function all the time. (defun read-from-buffer (&optional value buffer-name mode title keymap place highlight-list minor-modes) I suggest you implement some of these features: - I like to designate offen the buffer-name, it becomes more descriptive - Some text is in different modes, some strings are in html-mode, some are in markdown-mode, some in asciidoc mode, some are SQL mode, and so on; - I may need to pass keymap to function - I pass some minor-modes when necessary PLACE is something related to database, like database, column, ID, when I edit database objects, it is not related and not necessary to this general function -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/