unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ofv@wanadoo.es, deng@randomsample.de, mattiase@acm.org,
	emacs-devel@gnu.org, gregory@heytings.org, larsi@gnus.org
Subject: Re: Timings for 'make check' with and without symbols with position
Date: Sun, 27 Feb 2022 12:15:14 +0000	[thread overview]
Message-ID: <YhtrUtg9CGJaPgN0@ACM> (raw)
In-Reply-To: <83bkytpnyt.fsf@gnu.org>

Hello, Eli.

On Sat, Feb 26, 2022 at 18:55:06 +0200, Eli Zaretskii wrote:
> > Date: Sat, 26 Feb 2022 16:39:05 +0000
> > Cc: David Engster <deng@randomsample.de>, Eli Zaretskii <eliz@gnu.org>,
> >   larsi@gnus.org, mattiase@acm.org, gregory@heytings.org,
> >   Óscar Fuentes <ofv@wanadoo.es>
> > From: Alan Mackenzie <acm@muc.de>
> > 
> > Short summary: The new build is slower than the old by 12.6%.  perf
> > counted 419k samples on the new, 372k samples on the old.
> > 
> > What is taking the extra time is largely the garbage collection:  I
> > filtered perf's output successively for the strings "mark" and "sweep",
> > and include those functions with at least 0.1% of the run time.

> Thanks.  Any idea why there will be more GC in the new version?

Char-tables seem to have something to do with it.  The perf output for
mark_char_table increase from 2.98% to 3.79%.  Adding the 12.6% factor
onto the 3.79% gives us 4.27%.  That's a factor of ~1.5 increase.

I'm still slogging through the detailed output for mark_char_table,
which is not easy in the optimised build.  I suspect that somehow,
somewhere, symbols with position have got themselves into a char-table,
and they take (a lot) longer to process than bare symbols (for which
mark_char_table is optimised).  I've not yet managed to find such a
char-table though.

> Or are you saying the number of GC calls was the same, but each GC
> cycle took a bit longer?

I've tried to get an output of gcs-done at the end of the batch emacs
invocation in make check, but not yet managed it.  Maybe later.

> If so, how does symbols-with-pos affect GC?

I don't yet have a hypothesis for this.

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2022-02-27 12:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-26 16:39 Timings for 'make check' with and without symbols with position Alan Mackenzie
2022-02-26 16:55 ` Eli Zaretskii
2022-02-27 12:15   ` Alan Mackenzie [this message]
2022-02-27 12:34     ` Eli Zaretskii
2022-03-01 19:59       ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhtrUtg9CGJaPgN0@ACM \
    --to=acm@muc.de \
    --cc=deng@randomsample.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gregory@heytings.org \
    --cc=larsi@gnus.org \
    --cc=mattiase@acm.org \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).