From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sat, 19 Feb 2022 22:03:35 +0000 Message-ID: References: <838ruq2z5t.fsf@gnu.org> <83v8xt20db.fsf@gnu.org> <83ee4gyzrh.fsf@gnu.org> <83v8xryh4d.fsf@gnu.org> <831qzyzt5t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26305"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, mattiase@acm.org, gregory@heytings.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 19 23:04:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLXq7-0006ci-8a for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Feb 2022 23:04:27 +0100 Original-Received: from localhost ([::1]:47450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLXq5-0003IV-V3 for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Feb 2022 17:04:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLXpN-0002eC-VG for emacs-devel@gnu.org; Sat, 19 Feb 2022 17:03:41 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:41074 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1nLXpL-0000Y8-Iy for emacs-devel@gnu.org; Sat, 19 Feb 2022 17:03:41 -0500 Original-Received: (qmail 91369 invoked by uid 3782); 19 Feb 2022 22:03:37 -0000 Original-Received: from acm.muc.de (p4fe159ac.dip0.t-ipconnect.de [79.225.89.172]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 19 Feb 2022 23:03:37 +0100 Original-Received: (qmail 9459 invoked by uid 1000); 19 Feb 2022 22:03:35 -0000 Content-Disposition: inline In-Reply-To: <831qzyzt5t.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286495 Archived-At: Hello, Eli. On Sat, Feb 19, 2022 at 19:02:22 +0200, Eli Zaretskii wrote: > > Date: Sat, 19 Feb 2022 16:42:07 +0000 > > Cc: gregory@heytings.org, monnier@iro.umontreal.ca, mattiase@acm.org, > > larsi@gnus.org, emacs-devel@gnu.org > > From: Alan Mackenzie > > I haven't got any useful information out of the exercise, so far. I > > can't help feeling that I'm missing something. Is there anything I ought > > to be doing that I've not yet done? > Maybe you should make EQ real function, with an attribute that would > preclude its inlining. That's an excellent idea! Thanks! I managed to get that working. I reconfigured old and new without native compilation (in which it would be more work to de-inline EQ) and rebuilt them. I ran make check on each of them to have as many .elc files built as possible. On running $ perf record -e cpu-clock make check $ mv perf.data $ perf report -i --tui I found EQ taking 1.48% on the old build and 0.84% on the new build. Yes, I haven't got them the wrong way round. I saw the same on two consecutive runs for both builds, and the number of samples involved (several thousand) was enough to eliminate random wrongness. I don't understand what I'm seeing. -- Alan Mackenzie (Nuremberg, Germany).