From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Timings for 'make check' with and without symbols with position Date: Tue, 1 Mar 2022 19:59:10 +0000 Message-ID: References: <83bkytpnyt.fsf@gnu.org> <83ilt0o5db.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5014"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ofv@wanadoo.es, deng@randomsample.de, mattiase@acm.org, emacs-devel@gnu.org, gregory@heytings.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 01 21:02:51 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP8hv-00012H-0i for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Mar 2022 21:02:51 +0100 Original-Received: from localhost ([::1]:56250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nP8ht-0004mT-Sm for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Mar 2022 15:02:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nP8ek-0002hQ-45 for emacs-devel@gnu.org; Tue, 01 Mar 2022 14:59:41 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:48959 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1nP8eb-0007p8-F1 for emacs-devel@gnu.org; Tue, 01 Mar 2022 14:59:33 -0500 Original-Received: (qmail 1013 invoked by uid 3782); 1 Mar 2022 19:59:11 -0000 Original-Received: from acm.muc.de (p4fe15599.dip0.t-ipconnect.de [79.225.85.153]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 01 Mar 2022 20:59:10 +0100 Original-Received: (qmail 11092 invoked by uid 1000); 1 Mar 2022 19:59:10 -0000 Content-Disposition: inline In-Reply-To: <83ilt0o5db.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286757 Archived-At: Hello, Eli. On Sun, Feb 27, 2022 at 14:34:24 +0200, Eli Zaretskii wrote: > > Date: Sun, 27 Feb 2022 12:15:14 +0000 > > From: Alan Mackenzie > > Cc: ofv@wanadoo.es, deng@randomsample.de, mattiase@acm.org, emacs-devel@gnu.org, > > gregory@heytings.org, larsi@gnus.org > > Char-tables seem to have something to do with it. The perf output for > > mark_char_table increase from 2.98% to 3.79%. Adding the 12.6% factor > > onto the 3.79% gives us 4.27%. That's a factor of ~1.5 increase. > > I'm still slogging through the detailed output for mark_char_table, > > which is not easy in the optimised build. I suspect that somehow, > > somewhere, symbols with position have got themselves into a char-table, > > and they take (a lot) longer to process than bare symbols (for which > > mark_char_table is optimised). I've not yet managed to find such a > > char-table though. > We do have a few char-tables whose slots are symbols or include > symbols. unicode-category-table is one, for example; > composition-function-table is another. I've instrumented mark_char_table to try and detect symbols with position, but got no hits. I similarly instrumented mark_vectorlike, but the only hits I got there seemed to be when a compilation was in progress. So elucidation eludes me, so far. I'll need to look at it in some other fashion (suggestions welcome). -- Alan Mackenzie (Nuremberg, Germany).