From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH]: Re: Early backtrace. Date: Mon, 31 Jan 2022 16:54:09 +0000 Message-ID: References: <83pmo884b3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6710"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 31 17:56:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEZyf-0001Z7-KZ for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Jan 2022 17:56:29 +0100 Original-Received: from localhost ([::1]:54944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEZye-00056h-6S for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Jan 2022 11:56:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEZws-0003S6-Er for emacs-devel@gnu.org; Mon, 31 Jan 2022 11:54:38 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:31587 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1nEZwq-0005YX-B1 for emacs-devel@gnu.org; Mon, 31 Jan 2022 11:54:38 -0500 Original-Received: (qmail 14479 invoked by uid 3782); 31 Jan 2022 16:54:12 -0000 Original-Received: from acm.muc.de (p4fe159eb.dip0.t-ipconnect.de [79.225.89.235]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 31 Jan 2022 17:54:12 +0100 Original-Received: (qmail 5891 invoked by uid 1000); 31 Jan 2022 16:54:09 -0000 Content-Disposition: inline In-Reply-To: <83pmo884b3.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285685 Archived-At: Hello, Eli. On Mon, Jan 31, 2022 at 14:42:24 +0200, Eli Zaretskii wrote: > > From: Philipp Stephani > > Date: Mon, 31 Jan 2022 10:30:35 +0100 > > Cc: Stefan Monnier , > > Emacs developers > > Am So., 30. Jan. 2022 um 12:08 Uhr schrieb Alan Mackenzie : > > > It also fixes a bug in signal_or_quit (eval.c) where previously there > > > was: > > > specbind (Vdebugger, Qdebug); > > > , which had the effect of binding the contents of Vdebugger (namely > > > Qdebug) to itself. Correct would have been: > > > specbind (Qdebugger, Qdebug); > > > , binding the symbol Qdebugger to Qdebug. > > Good find, thanks. Independent of the rest of the patch, should we > > install this one-character fix on the release branch? > Yes, please. OK, I'll do that, but it's slightly more than one character to change. A DEFSYM for Qdebugger is also needed in syms_of_eval. > > Maybe that would even make commit > > 07edc28bdbfeeaeb1008b4fe21bfda586feae562 unnecessary? (Haven't > > checked, though.) > I wouldn't touch that part, as it cannot possibly do any harm. -- Alan Mackenzie (Nuremberg, Germany).