From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: make check error in native compiler resulting from commit 1cd188799f86bcb13ad76e82e3436b1b7e9f9e9f on 2021-12-30. Date: Sat, 5 Feb 2022 15:15:39 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30561"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 05 16:17:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGMoF-0007mC-KO for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Feb 2022 16:17:07 +0100 Original-Received: from localhost ([::1]:34232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGMoE-0001K2-2h for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Feb 2022 10:17:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGMnR-0000MF-2W for emacs-devel@gnu.org; Sat, 05 Feb 2022 10:16:17 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:26851 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1nGMnJ-0004We-Td for emacs-devel@gnu.org; Sat, 05 Feb 2022 10:16:16 -0500 Original-Received: (qmail 43003 invoked by uid 3782); 5 Feb 2022 15:15:43 -0000 Original-Received: from acm.muc.de (p2e5d5062.dip0.t-ipconnect.de [46.93.80.98]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 05 Feb 2022 16:15:43 +0100 Original-Received: (qmail 9779 invoked by uid 1000); 5 Feb 2022 15:15:39 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285903 Archived-At: Hello, Andrea. On Fri, Feb 04, 2022 at 14:58:47 +0000, Andrea Corallo wrote: > Andrea Corallo writes: > > Alan Mackenzie writes: > >> In that patch, I made the following change so that a comparison > >> involving Qnil would not go through the (newly) expensive emit_EQ: > >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > >> index 0a10505257..8581fe8066 100644 > >> --- a/lisp/emacs-lisp/comp.el > >> +++ b/lisp/emacs-lisp/comp.el > >> @@ -1829,9 +1829,7 @@ comp-limplify-lap-inst > >> (byte-listp auto) > >> (byte-eq auto) > >> (byte-memq auto) > >> - (byte-not > >> - (comp-emit-set-call (comp-call 'eq (comp-slot-n (comp-sp)) > >> - (make-comp-mvar :constant nil)))) > >> + (byte-not null) > >> (byte-car auto) > >> (byte-cdr auto) > >> (byte-cons auto) > Yeah, I think reverting this hunk and keeping the `eq' explicit in > LIMPLE is the right thing to do, it solves this specific issue and we > get back null and not inlined for free. > The explicit `eq' gets already nicely handled by the logic you have > added in comp.c:2244 so we emit libgccjit IR using emit_BASE_EQ in this > case. > I've pushed dcf30f14f9 to do that as it works here. OK, thank you! > Thanks > Andrea -- Alan Mackenzie (Nuremberg, Germany).