From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sat, 22 Jan 2022 15:09:17 +0000 Message-ID: References: <83mtjwzwkb.fsf@gnu.org> <87r198ytog.fsf@gnus.org> <87zgnvyb5y.fsf@gnus.org> <87bl03j10s.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31081"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 22 16:16:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBI7h-0007tu-C3 for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 16:16:13 +0100 Original-Received: from localhost ([::1]:53246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBI7g-00053e-Ad for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 10:16:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBI18-0000uE-1b for emacs-devel@gnu.org; Sat, 22 Jan 2022 10:09:26 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:13256 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1nBI15-0004Hl-Qt for emacs-devel@gnu.org; Sat, 22 Jan 2022 10:09:25 -0500 Original-Received: (qmail 49193 invoked by uid 3782); 22 Jan 2022 15:09:21 -0000 Original-Received: from acm.muc.de (p2e5d54f8.dip0.t-ipconnect.de [46.93.84.248]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 22 Jan 2022 16:09:21 +0100 Original-Received: (qmail 27400 invoked by uid 1000); 22 Jan 2022 15:09:17 -0000 Content-Disposition: inline In-Reply-To: <87bl03j10s.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285213 Archived-At: Hello, Lars. On Sat, Jan 22, 2022 at 15:30:43 +0100, Lars Ingebrigtsen wrote: > Alan Mackenzie writes: > > I now propose to merge the branch into master. Do you (or anybody else) > > still have any issues with this? > I'd like to see the results from elisp-benchmarks with and without this > patch set, please. Certainly! Each of the following two sets of results was obtained from my machine starting emacs --no-desktop, and represents the second run of elisp-benchmarks on each build. The state of master was merged into the branch this morning, and both builds were redone this morning, too. Branch scratch/correct-warning-pos: | test | non-gc avg (s) | gc avg (s) | gcs avg | tot avg (s) | tot avg err (s) | |--------------------+----------------+------------+---------+-------------+-----------------| | inclist | 1.33 | 0.00 | 0 | 1.33 | 0.00 | | fibn-rec | 0.00 | 0.00 | 0 | 0.00 | 0.00 | | listlen-tc | 0.13 | 0.00 | 0 | 0.13 | 0.00 | | pack-unpack | 0.14 | 0.12 | 4 | 0.26 | 0.00 | | pidigits | 5.18 | 5.82 | 170 | 11.00 | 0.01 | | map-closure | 10.98 | 0.00 | 0 | 10.98 | 0.01 | | nbody | 1.98 | 0.24 | 1 | 2.22 | 0.01 | | dhrystone | 2.92 | 0.00 | 0 | 2.92 | 0.02 | | pack-unpack-old | 0.21 | 0.28 | 9 | 0.49 | 0.00 | | bubble | 1.51 | 0.13 | 1 | 1.64 | 0.00 | | inclist-type-hints | 1.14 | 0.00 | 0 | 1.14 | 0.01 | | bubble-no-cons | 2.42 | 0.03 | 1 | 2.46 | 0.02 | | fibn | 0.00 | 0.00 | 0 | 0.00 | 0.00 | | fibn-tc | 0.01 | 0.00 | 0 | 0.01 | 0.00 | | pcase | 1.97 | 0.00 | 0 | 1.97 | 0.00 | | flet | 4.27 | 0.00 | 0 | 4.27 | 0.00 | |--------------------+----------------+------------+---------+-------------+-----------------| | total | 34.19 | 6.62 | 186 | 40.81 | 0.03 | And master: | test | non-gc avg (s) | gc avg (s) | gcs avg | tot avg (s) | tot avg err (s) | |--------------------+----------------+------------+---------+-------------+-----------------| | inclist | 1.35 | 0.00 | 0 | 1.35 | 0.01 | | fibn-rec | 0.00 | 0.00 | 0 | 0.00 | 0.00 | | listlen-tc | 0.13 | 0.00 | 0 | 0.13 | 0.00 | | pack-unpack | 0.14 | 0.14 | 5 | 0.28 | 0.00 | | pidigits | 5.38 | 5.83 | 184 | 11.21 | 0.00 | | map-closure | 9.69 | 0.00 | 0 | 9.69 | 0.00 | | nbody | 1.86 | 0.24 | 1 | 2.09 | 0.01 | | dhrystone | 2.91 | 0.00 | 0 | 2.91 | 0.01 | | pack-unpack-old | 0.20 | 0.28 | 10 | 0.49 | 0.00 | | bubble | 1.58 | 0.12 | 1 | 1.70 | 0.04 | | inclist-type-hints | 1.14 | 0.00 | 0 | 1.14 | 0.02 | | bubble-no-cons | 2.34 | 0.03 | 1 | 2.37 | 0.00 | | fibn | 0.00 | 0.00 | 0 | 0.00 | 0.00 | | fibn-tc | 0.01 | 0.00 | 0 | 0.01 | 0.00 | | pcase | 2.08 | 0.00 | 0 | 2.08 | 0.00 | | flet | 4.37 | 0.00 | 0 | 4.37 | 0.01 | |--------------------+----------------+------------+---------+-------------+-----------------| | total | 33.17 | 6.64 | 202 | 39.81 | 0.05 | > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).