From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sun, 16 Jan 2022 13:47:48 +0000 Message-ID: References: <83mtjwzwkb.fsf@gnu.org> <87r198ytog.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25222"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 16 14:48:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n95tf-0006MY-Hd for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Jan 2022 14:48:39 +0100 Original-Received: from localhost ([::1]:39072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n95te-0002vF-1o for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Jan 2022 08:48:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n95sy-0002FF-Mz for emacs-devel@gnu.org; Sun, 16 Jan 2022 08:47:56 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:56835 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1n95sw-00042T-Ix for emacs-devel@gnu.org; Sun, 16 Jan 2022 08:47:56 -0500 Original-Received: (qmail 13462 invoked by uid 3782); 16 Jan 2022 13:47:52 -0000 Original-Received: from acm.muc.de (p2e5d50dc.dip0.t-ipconnect.de [46.93.80.220]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 16 Jan 2022 14:47:51 +0100 Original-Received: (qmail 32231 invoked by uid 1000); 16 Jan 2022 13:47:48 -0000 Content-Disposition: inline In-Reply-To: <87r198ytog.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284813 Archived-At: Hello, Lars. On Sun, Jan 16, 2022 at 09:24:31 +0100, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > >> So, I would propose to merge the branch into master now. What do people > >> (in particular Eli) say about this? > > Fine with me if Lars agrees. > I'm seeing one compilation warning on the branch: > Compiler-macro error for cl-member: Handler: cl--compiler-macro-member > (excessive-variable-binding) > Eager macro-expansion failure: (excessive-variable-binding) I don't see this any more (though I've seen plenty of the like in the past two or three weeks). Was that build a bootstrap build? > And a "time make -j8 bootstrap check" takes > real 3m31.160s > while it's > real 3m16.761s > on master. A 7% slowdown is rather significant. I suspect there is more conditional branching happening in the test suite than in "normal" Lisp code. Also, the bootstrap is doing more work - it is keeping track of source positions for correct warning messages, something master doesn't do. To keep things in perspective, solving the recent bug #53164 took about the same amount off the build time. The way to reduce the bootstrap time is surely to build lisp/emacs-lisp/comp.el with a byte-compiled compiler rather than the interpreted source one. This latter takes about 2½ minutes on my machine. > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).