From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.devel Subject: Re: master b5393c6 2/3: Silence undefined function warnings in eieio-tests.el Date: Sun, 9 Jan 2022 22:19:02 +0300 Message-ID: References: <20211220151236.23091.98968@vcs0.savannah.gnu.org> <20211220151238.2DADD209AC@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13439"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.7+183 (3d24855) (2021-05-28) Cc: Stefan Monnier , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 09 20:24:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6dns-0003HD-97 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jan 2022 20:24:32 +0100 Original-Received: from localhost ([::1]:44532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6dnq-0006VA-Bi for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jan 2022 14:24:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6dml-0005mU-Vp for emacs-devel@gnu.org; Sun, 09 Jan 2022 14:23:24 -0500 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:38221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6dmf-0007rU-S6 for emacs-devel@gnu.org; Sun, 09 Jan 2022 14:23:20 -0500 Original-Received: from localhost ([::ffff:41.210.155.59]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 0000000000038059.0000000061DB361E.000031C3; Sun, 09 Jan 2022 12:23:10 -0700 Mail-Followup-To: Stefan Kangas , Stefan Monnier , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284506 Archived-At: * Stefan Kangas [2021-12-21 13:55]: > Stefan Monnier writes: > > >> +;; Silence byte-compiler. > >> +(defun eitest-subordinate--eieio-childp ()) > >> +(defun class-alloc-initarg--eieio-childp ()) > > > > Hmm... I don't understand this code. > > If `declare-function` can't be used, we should have a comment > > explaining why. > > Duh, I somehow forgot that I can use that also for Lisp functions. > > Now fixed, thanks. > > BTW, there are only four remaining warnings in the test suite if someone who > knows eieio feels like taking a look. What I know is that I cannot run helm and other packages because in latest development version I am getting: byte-code: Symbol’s function definition is void: eieio--defgeneric-init-form -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/