From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Correct byte compiler error/warning positions. The solution! Date: Wed, 1 Dec 2021 17:21:16 +0000 Message-ID: References: <83wnktzxb2.fsf@gnu.org> <83ilwcyc6o.fsf@gnu.org> <8335nfw2pe.fsf@gnu.org> <838rx4s224.fsf@gnu.org> <87k0gojlxl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7698"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 01 18:32:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msTSa-0001nS-9r for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 18:32:00 +0100 Original-Received: from localhost ([::1]:60836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msTSZ-0001Rd-09 for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 12:31:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msTIK-0006PN-JO for emacs-devel@gnu.org; Wed, 01 Dec 2021 12:21:24 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:43409 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1msTII-0006HA-8q for emacs-devel@gnu.org; Wed, 01 Dec 2021 12:21:24 -0500 Original-Received: (qmail 63437 invoked by uid 3782); 1 Dec 2021 17:21:20 -0000 Original-Received: from acm.muc.de (p4fe15d91.dip0.t-ipconnect.de [79.225.93.145]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 01 Dec 2021 18:21:20 +0100 Original-Received: (qmail 11538 invoked by uid 1000); 1 Dec 2021 17:21:16 -0000 Content-Disposition: inline In-Reply-To: <87k0gojlxl.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280656 Archived-At: Hello, Lars. On Wed, Dec 01, 2021 at 18:04:54 +0100, Lars Ingebrigtsen wrote: > Alan Mackenzie writes: > > I would like to merge this branch, when it becomes stable, into master, > > thus finally resolving the bug of the wrong positions in warning > > messages from the byte compiler. > > Comments would be welcome. > Would this mean that other parts of the byte compilation machinery would > need to be changed, since two symbols read while doing that won't be > `eq' any more? The branch is working code, capable of bootstrapping Emacs, at least in a non-native-code configuration. lisp_h_EQ (in lisp.h) has been modified such that # is `eq' #. The compilation machinery is basically unchanged. > Does the positions leak out from the symbols anywhere else, like when > doing reads outside the byte compilation process? `read' is as it always was. There is a new function `read-positioning-symbols' which returns symbols (apart from nil) as symbols-with-position. It is called only from the byte compiler. Any such leakages are bugs to fix. This we can do. > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).