From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Correct byte compiler error/warning positions. The solution! Date: Wed, 1 Dec 2021 17:12:14 +0000 Message-ID: References: <83wnktzxb2.fsf@gnu.org> <83ilwcyc6o.fsf@gnu.org> <8335nfw2pe.fsf@gnu.org> <838rx4s224.fsf@gnu.org> <834k7ss172.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36165"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 01 18:29:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msTQD-0009CA-W1 for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 18:29:33 +0100 Original-Received: from localhost ([::1]:56400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msTQC-0006pF-E3 for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 12:29:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msT9f-0007dO-NS for emacs-devel@gnu.org; Wed, 01 Dec 2021 12:12:27 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:43156 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1msT9Y-0003dI-Qk for emacs-devel@gnu.org; Wed, 01 Dec 2021 12:12:23 -0500 Original-Received: (qmail 57731 invoked by uid 3782); 1 Dec 2021 17:12:18 -0000 Original-Received: from acm.muc.de (p4fe15d91.dip0.t-ipconnect.de [79.225.93.145]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 01 Dec 2021 18:12:18 +0100 Original-Received: (qmail 11532 invoked by uid 1000); 1 Dec 2021 17:12:14 -0000 Content-Disposition: inline In-Reply-To: <834k7ss172.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280655 Archived-At: Hello, Eli. On Wed, Dec 01, 2021 at 19:08:01 +0200, Eli Zaretskii wrote: > > Date: Wed, 1 Dec 2021 16:58:52 +0000 > > Cc: emacs-devel@gnu.org > > From: Alan Mackenzie > > You asked me for some benchmark figures comparing master with the > > scratch/correct-warning-pos branch. I supplied them, and they suggest > > that the performance penalty in the new branch is small, around 1%. > 1% slowdown is insignificant. But Andrea suggested to use an > additional suite of benchmarks, and I thought you were going to do > that as well. I'm intending to. At the moment, I'm looking at getting it working with native-compilation. > > I would like to merge this branch, when it becomes stable, into master, > > thus finally resolving the bug of the wrong positions in warning > > messages from the byte compiler. > If all the benchmarks show a slowdown <= 1%, I'm okay with merging it. Thanks! -- Alan Mackenzie (Nuremberg, Germany).