From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Correct byte compiler error/warning positions. The solution! Date: Wed, 1 Dec 2021 16:46:09 +0000 Message-ID: References: <83pmqm16vz.fsf@gnu.org> <8335nh29pt.fsf@gnu.org> <83wnktzxb2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29312"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 01 17:48:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msSme-0007Jx-Jz for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 17:48:40 +0100 Original-Received: from localhost ([::1]:42674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msSmd-0000S2-B5 for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 11:48:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msSkO-0006UG-AW for emacs-devel@gnu.org; Wed, 01 Dec 2021 11:46:20 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:42436 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1msSkK-0004yV-3S for emacs-devel@gnu.org; Wed, 01 Dec 2021 11:46:20 -0500 Original-Received: (qmail 39023 invoked by uid 3782); 1 Dec 2021 16:46:14 -0000 Original-Received: from acm.muc.de (p4fe15d91.dip0.t-ipconnect.de [79.225.93.145]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 01 Dec 2021 17:46:13 +0100 Original-Received: (qmail 11445 invoked by uid 1000); 1 Dec 2021 16:46:09 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280640 Archived-At: Hello, Andrea. On Wed, Dec 01, 2021 at 16:18:48 +0000, Andrea Corallo wrote: > Andrea Corallo writes: > > Hi Alan, > > I think would be interesting to have a comparative run also using > > > > Andrea > Adding on this, > given we should very carefully evaluate the performance impact (one > single benchmark is certainly not sufficient), I think we should stay > away for solutions adding performance cost to the run-time. Any help evaluating the performance of the scratch/correct-warning-pos branch would certainly be appreciated. > There's no question we'll have to pay a cost for this, but the other > solutions on the table (hashing conses or fat conses) are impacting only > the compile time and therefore IMO should definitely be preferred. One great advantage of the current approach is that it's implemented working code. Well, almost (it doesn't yet work with native-compilation enabled). The disadvantage in performance, as measured so far by me, is so small (less than 1%) as to be negligible. The bug reports about warning positions being wrong have remained unresolved for many years. It is surely now time to fix them with scratch/correct-warning-pos when it becomes stable. If there come to be better ways of addressing the problem in the future, then one of those ways could supersede the current proposal when it becomes available. > Regards > Andrea -- Alan Mackenzie (Nuremberg, Germany).