From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: What's the point of byte-compile-define-keymap? Date: Sat, 27 Nov 2021 16:36:47 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23092"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 27 17:37:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mr0hu-0005sZ-T9 for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 17:37:46 +0100 Original-Received: from localhost ([::1]:55634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mr0ht-0008CP-FR for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 11:37:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mr0h2-0007Rf-CB for emacs-devel@gnu.org; Sat, 27 Nov 2021 11:36:52 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:55545 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1mr0h0-0005Lt-CR for emacs-devel@gnu.org; Sat, 27 Nov 2021 11:36:52 -0500 Original-Received: (qmail 49920 invoked by uid 3782); 27 Nov 2021 16:36:48 -0000 Original-Received: from acm.muc.de (p2e5d5030.dip0.t-ipconnect.de [46.93.80.48]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 27 Nov 2021 17:36:47 +0100 Original-Received: (qmail 10894 invoked by uid 1000); 27 Nov 2021 16:36:47 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280349 Archived-At: Hello, Emacs. It looks to me that byte-compile-define-keymap (in lisp/emacs-lisp/bytecomp.el) saves its FORM argument in ORIG-FORM and always returns it unchanged. This looks like an oversight. Also, would this function not better be named byte-compile-FILE-FORM-define-keymap, since it is the value of a byte-hunk-handler symbol property. Also[2], is this function really necessary? Is define-keymap used sufficiently often to justify a special byte-hunk-handler for it? -- Alan Mackenzie (Nuremberg, Germany).