From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: master 2c79a8f 2/2: Use posix_spawn if possible. Date: Tue, 2 Nov 2021 20:36:04 +0000 Message-ID: References: <86k0swut21.fsf@gmail.com> <861rf4nnuj.fsf@gmail.com> <83czyng78z.fsf@gnu.org> <87eej3wwbp.fsf@linux-m68k.org> <83tuguiaam.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15877"; mail-complaints-to="usenet@ciao.gmane.io" Cc: p.stephani2@gmail.com, mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 02 21:37:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mi0X4-0003vG-Ee for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Nov 2021 21:37:22 +0100 Original-Received: from localhost ([::1]:53542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mi0X3-0001UD-9s for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Nov 2021 16:37:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mi0W0-0000nm-Gx for emacs-devel@gnu.org; Tue, 02 Nov 2021 16:36:16 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:37019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mi0Vx-0002uW-Ms; Tue, 02 Nov 2021 16:36:15 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id EDE8551; Tue, 2 Nov 2021 20:36:08 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1635885367; bh=f/Bn+Fst9KRGboz6Q0wpXjgAWO1MEElmkUgp6Zyboiw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K48L38NgdxlfX7itBr/3UZVedfBb6QYYe4PQGWBocZFgEjpaeOuquRFCaM6xN5rgq 4+xLmTKl+0/mOsmiTa0WTES3FeZqDOiozjFlACcgtM6nzZ/Y3CFpWHDwBUwkbHCz2F 6sejHuYidP+RWaUvOW47dutKtTSYroTRIc1R8zjxK8QMjOnoQGPWmf2xBWA0AzwCzX BiIK1QBAOzwo6f96f/CeJlmOk7VklgK9znYvJuewD8b2SzqSxcVEDKKkJ3C9+yq1VY E16U/1wNDUdebtNTSSF/ZRoEwKLkPHmUYqGXZ9fOGQ2+KPvs686IrZfKf+SwzGbc6m 4PS7O59DSMWQg== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mi0Vo-0009f2-NT; Tue, 02 Nov 2021 20:36:04 +0000 Mail-Followup-To: Alan Third , Eli Zaretskii , p.stephani2@gmail.com, mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <83tuguiaam.fsf@gnu.org> Received-SPF: pass client-ip=116.202.126.228; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278538 Archived-At: On Tue, Nov 02, 2021 at 10:15:29PM +0200, Eli Zaretskii wrote: > > Date: Tue, 2 Nov 2021 19:58:10 +0000 > > From: Alan Third > > Cc: Philipp Stephani > > > > When we put in the fix to use vfork on macOS back in Emacs 26 the > > measured difference between fork and vfork was something like 15x. Now > > Apple have turned vfork into fork I guess we're back to the same > > situation. Packages that make heavy use of external processes, such as > > Magit, are badly hit by this slow down. > > > > Is there anything we need to do to get scratch/posix-spawn-no-gnulib > > merged into master (or even emacs-28)? > > Does it solve the problem? And which builds does it affect? As I understand it Yamamoto Mitsuharu has already merged it into the Mac port and I've seen it reported that the problems are solved with it. I don't have a Mac with the latest macOS on to test it myself. This is really only a problem on macOS, so we could limit the use of posix_spawn to Darwin builds. I am concerned that there could be hidden issues with the branch since it doesn't seem to have had much testing, so it's probably best going into master, but I expect we'll see an increasing number of complaints about performance as more people switch to macOS 12. Perhaps we should keep it in mind as a possible update for 28.2, whenever that may be. -- Alan Third