From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: master 2c79a8f 2/2: Use posix_spawn if possible. Date: Fri, 12 Nov 2021 22:05:19 +0000 Message-ID: References: <83v91145uz.fsf@gnu.org> <365F6090-6900-4895-9FEB-90AA542CA02F@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4295"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp , Eli Zaretskii , YAMAMOTO Mitsuharu , Emacs developers To: Aaron Jensen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 12 23:06:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlegc-0000sa-UZ for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Nov 2021 23:06:19 +0100 Original-Received: from localhost ([::1]:54172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlegb-0003EP-Qh for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Nov 2021 17:06:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlefq-0002SX-Jg for emacs-devel@gnu.org; Fri, 12 Nov 2021 17:05:30 -0500 Original-Received: from outbound.soverin.net ([116.202.126.228]:50337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlefo-0000fR-29; Fri, 12 Nov 2021 17:05:30 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id EAA1C8B0; Fri, 12 Nov 2021 22:05:24 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1636754723; bh=tvh0whHlgXYVoxa5ENRijxIy8+6kitGyHWU5VLElSRQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eQC8jvwSPhVLMS3UWSp5l18cG+ny786G+0eD9vr9smOOgSKZnmRA3i48IllU+X7RF E9+ASQ0ghCcSAAk6rxkxp0yGmXKhswW4rIduW1/AwJuMISrVuDKzWR4tkqd+hPECe5 AHuQrt4Lutq0lt8lcNl0QBPE6Q8PozahGXEO5rW4sCSTW3YglcYNQ0cuzx80q5gBhn NJy8dYh4WmcF6XZEB1/XOsyIg3jLQh9OBwDptQ+mbBsk4Dz2VO8NS6DWrU7GNKI6J9 1+MaBD7L0ZfScWC8ZnYwtnIUwtA+RGyHbVRmkZg7bCR/YOvSt1otVQPYWJerkvIfLL NcmErR4/aZhfQ== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mleff-000HUa-Rd; Fri, 12 Nov 2021 22:05:19 +0000 Mail-Followup-To: Alan Third , Aaron Jensen , Philipp , Eli Zaretskii , YAMAMOTO Mitsuharu , Emacs developers Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=116.202.126.228; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279297 Archived-At: On Fri, Nov 12, 2021 at 08:42:57AM -0500, Aaron Jensen wrote: > On Fri, Nov 12, 2021 at 6:48 AM Philipp wrote: > > > For now I did the second part. There's a small slowdown on GNU/Linux (because posix_spawn performs a few additional safety checks), and a large speedup on macOS, see the attached plot > > Great, thanks. I've added the patch to the homebrew installed > emacs-plus for version 28, which is one of the more popular ways of > installing Emacs on macOS. I believe a future version of emacs-mac > will have the patch applied too, so there's not necessarily a rush to > patch 28 and we will be getting some testing. I think emacsformacosx.com builds dwarf pretty much any other macOS builds in terms of user-base, and IIRC they're totally vanilla, so we still might want to install this on the release branch only for macOS. -- Alan Third